Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation guide missing initial npm installation #10

Closed
deckar01 opened this issue Aug 5, 2015 · 7 comments
Closed

Installation guide missing initial npm installation #10

deckar01 opened this issue Aug 5, 2015 · 7 comments

Comments

@deckar01
Copy link

deckar01 commented Aug 5, 2015

Current behavior:
The installation guide starts with configuration and does not walk the dev through npm installation.

The installation step "open the temp.env file located in the lib folder" assumes the module is installed in the application, but does not list it as a prerequisite step.

Expected behavior:
The installation guide should start with running the command npm install --save jaws-stack in their project.

Notes:
Trivial, but a potential stumbling block.

@deckar01
Copy link
Author

deckar01 commented Aug 5, 2015

It also wouldn't hurt to include it in the readme.

@ac360
Copy link
Member

ac360 commented Aug 5, 2015

Thanks. I'll fix this right away!

@ac360
Copy link
Member

ac360 commented Aug 5, 2015

Done.

@ac360 ac360 closed this as completed Aug 5, 2015
@deckar01
Copy link
Author

deckar01 commented Aug 5, 2015

I'm not exactly sure what you changed, but the wiki doesn't seem to have the info I was suggesting.

Using pull requests and referencing their issues helps keep things organized (although the wiki doesn't exactly have PRs).

Issue #5 was closed without reference to the commit you made to fix it and will be lost in the sands of time.

@kraigh
Copy link

kraigh commented Aug 13, 2015

I also don't see this reflected in the wiki, and it took me a minute to poke around to find the npm module name.

@kraigh
Copy link

kraigh commented Aug 13, 2015

Side note: is there a good way to suggest wiki updates?

@robstolarz
Copy link

The edit button? If your revision is wrong, it can be undone. It doesn't need project leader approval, just like they do it on Wikipedia!

felixrieseberg pushed a commit to felixrieseberg/serverless that referenced this issue Jun 17, 2016
horike37 pushed a commit that referenced this issue Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants