Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type definitions are missing #166

Open
nikolaymatrosov opened this issue May 4, 2022 · 3 comments
Open

Type definitions are missing #166

nikolaymatrosov opened this issue May 4, 2022 · 3 comments

Comments

@nikolaymatrosov
Copy link

There are no type definitions for TypeScript. It causes errors.

@medikoo
Copy link
Contributor

medikoo commented May 4, 2022

@nikolaymatrosov it's not a TypeScript but a plain JavaScript project (same as the Serverless Framework).

Also, this package serves internal utils for the Serverless Framework, as is not intended for public use in its form directly.

@nikolaymatrosov
Copy link
Author

It is mentioned in the docs as a convenient way to retrieve the logger. I'm writing my plugin in TypeScript, so it would be great to have an opportunity to use the utils package there.

@medikoo
Copy link
Contributor

medikoo commented May 4, 2022

It is mentioned in the docs as a convenient way to retrieve the logger.

Indeed forgot about that. but note It's not a TypeScript project, so there's nothing wrong with it not having TS type definitions.

Nonetheless, I agree, that for improved IntelliSense it'll be helpful to provide typings. if you see an easy, non-invasive way to add them, PR's welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants