Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency 'org.json' has vulnerabilities #193

Closed
jrpedrianes opened this issue Apr 19, 2022 · 20 comments
Closed

Dependency 'org.json' has vulnerabilities #193

jrpedrianes opened this issue Apr 19, 2022 · 20 comments
Assignees
Labels
bug Something isn't working

Comments

@jrpedrianes
Copy link

jrpedrianes commented Apr 19, 2022

What happened:

Dependency org.json is a transitive dependency from everit-json-schema that has vulnerabilities (CVE Name: Cx78f40514-81ff)

stleary/JSON-java#484

The everit-json-schema maintainer released a new version fixing it: https://github.com/everit-org/json-schema/releases

@jrpedrianes jrpedrianes changed the title Dependency 'org.json' that is dependent by 'everit-json-schema' has vulnerabilities Dependency 'org.json' has vulnerabilities Apr 19, 2022
@tsurdilo tsurdilo self-assigned this Apr 19, 2022
@tsurdilo tsurdilo added the bug Something isn't working label Apr 19, 2022
@tsurdilo
Copy link
Collaborator

Thanks for reporting this. Will update and test.

@cb-manick
Copy link
Contributor

I will take a look at this

@jrpedrianes
Copy link
Author

Here you have a link where the issue is examined: stleary/JSON-java#484, the first is not correct 🤷‍♂️, I'm going to change it.

Also indicate that commons-validator depends on commons-collections and in version 1.6 has a minor issue, see:

https://issues.apache.org/jira/browse/COLLECTIONS-701
checkmarx-ts/checkmarx-github-action#187

@jrpedrianes
Copy link
Author

jrpedrianes commented Apr 19, 2022

sorry :(, closed by mistake 😮‍💨

@tsurdilo
Copy link
Collaborator

@jrpedrianes no problem, interested to find out what other projects are using for CVE reporting. Something free would be nice to have so we can react on these issues faster.

@jrpedrianes
Copy link
Author

jrpedrianes commented Apr 19, 2022

I think that you can use this https://github.com/apps/whitesource-for-github-com for free in github public repositories.

But Im not sure,

@tsurdilo
Copy link
Collaborator

Ok yeah let's give that try definitely, thanks.

@tsurdilo
Copy link
Collaborator

enabled for all sdk repos

@tsurdilo
Copy link
Collaborator

weird, whitesource is part of our build now but its not reporting this particular issue

@manick02
Copy link
Contributor

@jrpedrianes what tool identified this vulnerability? @tsurdilo how can I access vulnerability report for this repo

@tsurdilo
Copy link
Collaborator

tsurdilo commented Apr 20, 2022

@manick02 this was the last scan performed: https://github.com/serverlessworkflow/sdk-java/runs/6085322739
did not have any reported issues.
Probably still best to upgrade https://github.com/serverlessworkflow/sdk-java/blob/main/pom.xml#L62
to latest version 1.14.1 as @jrpedrianes mentioned - https://mvnrepository.com/artifact/com.github.erosb/everit-json-schema

that should be it for this issue i think (would also need to cherry-pick it to 4.0.x branch)

manick02 added a commit to manick02/sdk-java that referenced this issue Apr 20, 2022
Signed-off-by: manick02 <manickavasagam.sundaram@gmail.com>
@jrpedrianes
Copy link
Author

@manick02 I use a tool integrated into my IDE.

I use IntelliJ IDEA 2022.1 (Ultimate Edition) which has a panel called "Dependency checker" that alerts me of all these vulnerabilities. For example in your case alerts me two:

  • Cxdb5a1032-eda2
  • Cx78f40514-81ff

Captura de Pantalla 2022-04-20 a las 7 21 39

@jrpedrianes
Copy link
Author

jrpedrianes commented Apr 20, 2022

Seems that my IDE is using Checkmarx under the hood.

I don't know if this tool has a free plan, but seems that you can integrate it into Github:

or launch directly from maven:

Captura de Pantalla 2022-04-20 a las 7 40 12

@jrpedrianes
Copy link
Author

Also, Github has a tool named "Dependabot alerts", that scans the project dependencies, but I don't know if transitive ones are detected too. You can enable it in Settings -> Code security and analysis -> Dependabot alerts

@manick02
Copy link
Contributor

Thanks @jrpedrianes I will check it out, and will try to setup some form of this tool

@manick02 I use a tool integrated into my IDE.

I use IntelliJ IDEA 2022.1 (Ultimate Edition) which has a panel called "Dependency checker" that alerts me of all these vulnerabilities. For example in your case alerts me two:

  • Cxdb5a1032-eda2
  • Cx78f40514-81ff
Captura de Pantalla 2022-04-20 a las 7 21 39

@jrpedrianes
Copy link
Author

Any news about this?

@tsurdilo
Copy link
Collaborator

@manick02 ^^

@manick02
Copy link
Contributor

manick02 commented May 30, 2022

@tsurdilo fix for json schema vulnerability is already approved by you and its in main branch already

@tsurdilo
Copy link
Collaborator

oops sorry checking

@tsurdilo
Copy link
Collaborator

fixed via manick02@3c6813d

ricardozanini pushed a commit to ricardozanini/sdk-java that referenced this issue Jul 3, 2023
Signed-off-by: manick02 <manickavasagam.sundaram@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants