Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS deployment targets #627

Open
waywardmonkeys opened this issue Jul 29, 2023 · 2 comments
Open

macOS deployment targets #627

waywardmonkeys opened this issue Jul 29, 2023 · 2 comments

Comments

@waywardmonkeys
Copy link
Contributor

There's discussion elsewhere about changing the minimum macOS / iOS versions supported: rust-lang/rust#104385

There's Travis CI configs here that used to test this sort of thing for these crates.

I've opened #623 to remove those configs and this was also mentioned in #461.

What should the minimum targets be? How tested is this? Can we test with MACOSX_DEPLOYMENT_TARGET and modern Xcode? This appears to be what the main Rust CI is doing? Or is that only for include processing and not linking?

In any event, it would be good to get this clearly documented as well.

@madsmtm
Copy link
Contributor

madsmtm commented Jul 29, 2023

I'm somewhat working on doing version detection in madsmtm/objc2#266, just for reference.

If you want something that works now, then checking MACOSX_DEPLOYMENT_TARGET in build.rs is probably a viable solution

@thomcc
Copy link

thomcc commented Jul 30, 2023

rustc --print deployment-target works as of 1.71.0 (rust-lang/rust#105354)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants