Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove link feature? #651

Open
madsmtm opened this issue Dec 5, 2023 · 3 comments
Open

Remove link feature? #651

madsmtm opened this issue Dec 5, 2023 · 3 comments

Comments

@madsmtm
Copy link
Contributor

madsmtm commented Dec 5, 2023

Linking with -weak_framework is recently possible on nightly:

#![feature(link_arg_attribute)]

#[link(name = "-weak_framework", kind = "link-arg", modifiers = "+verbatim")]
#[link(name = "CoreFoundation", kind = "link-arg", modifiers = "+verbatim")]
extern "C" {}

This works even if declared in a binary crate that depends on something that has the normal #[link(name = "CoreFoundation", kind = "framework")].

Given that, maybe we should consider removing the link feature again?

@jrmuizel
Copy link
Collaborator

jrmuizel commented Dec 5, 2023

It probably makes sense for that to get to stable first right?

@madsmtm
Copy link
Contributor Author

madsmtm commented Dec 5, 2023

Depends on if the users are fine with using nightly, I guess? @crowlKats?

@crowlKats
Copy link
Contributor

crowlKats commented Dec 5, 2023

the reason we wanted this added was because the feature is nightly, and at Deno we do not want to build with nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants