Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question about globals in @serwist/core and globals.d.ts #132

Closed
userquin opened this issue Apr 24, 2024 · 5 comments
Closed

question about globals in @serwist/core and globals.d.ts #132

userquin opened this issue Apr 24, 2024 · 5 comments
Labels
stale This has gone stale due to inactivity

Comments

@userquin
Copy link
Contributor

userquin commented Apr 24, 2024

The dts is not included in the final package and it is not included in the subpackage exports, shouldn't it be in the distribution and included?

@DuCanhGH
Copy link
Member

@userquin ah, well, that file is only meant for development purposes. We expect the users to extend SerwistGlobalConfig themselves. Well, for now, at least.

Though, since that is only for development, I wonder if we should move the file up from the package. That would cause inspecting the shipped source code to show some more red squiggles though.

@userquin
Copy link
Contributor Author

userquin commented Apr 25, 2024

@DuCanhGH FYI: you can enable shell-emulator=true in .npmrc file and remove cross-env dev dependency and update all scripts using it, just declare env variables without cross-env prefix (all platforms): https://pnpm.io/cli/run#shell-emulator

@DuCanhGH
Copy link
Member

@userquin huh, thanks for the info :) Will investigate soon!

Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale This has gone stale due to inactivity label May 26, 2024
Copy link
Contributor

github-actions bot commented Jun 9, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This has gone stale due to inactivity
Projects
None yet
Development

No branches or pull requests

2 participants