Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Build fails if you follow setup guide Next.js #144

Closed
JesseKoldewijn opened this issue May 17, 2024 · 2 comments
Closed

[Docs]: Build fails if you follow setup guide Next.js #144

JesseKoldewijn opened this issue May 17, 2024 · 2 comments
Assignees
Labels
docs Improvements or additions to documentation triage New issues get this label, remove it after triage

Comments

@JesseKoldewijn
Copy link

Provide environment information

not required, is applicable to setup of serwist inside existing and new Next.js applications that use Typescript

Describe the problem

The lack of mentioning the need to exclude the swe output and sw inside your tsconfig results in failing builds with unclear error messages (messages come from next themselves so the precise message is unrelated to issue at hand)

Expected behavior

It might be useful to note the exclusion of the output files (which get dropped inside the public folder on build) inside the tsconfig/jsconfig (if applicable), eslint config (just for good measure) and inside your gitignore.

Screenshots (if relevant)

No response

Additional information (if relevant)

No response

@JesseKoldewijn JesseKoldewijn added docs Improvements or additions to documentation triage New issues get this label, remove it after triage labels May 17, 2024
@DuCanhGH
Copy link
Member

Ah, yeah, will fix the docs later! Thanks for noticing.

@DuCanhGH
Copy link
Member

I've fixed this as can be seen here! Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation triage New issues get this label, remove it after triage
Projects
None yet
Development

No branches or pull requests

2 participants