Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMA@18 #208

Closed
16 of 20 tasks
jsimck opened this issue May 27, 2022 · 1 comment · Fixed by #210, #212, #213, #214 or #218
Closed
16 of 20 tasks

IMA@18 #208

jsimck opened this issue May 27, 2022 · 1 comment · Fixed by #210, #212, #213, #214 or #218

Comments

@jsimck
Copy link
Contributor

jsimck commented May 27, 2022

This issue tracks progress towards IMA@18 release.

Missing features

Known issues

Potential improvements (don't need to be ready for IMA@18 release)

TODO

core

  • globals from setupFile are not visible to TS compiler (using, extend), some tests are commented out
  • RouteOptions type is defined in core but is using ComponentType from react - core should not have react dependency

react-page-renderer

  • some tests with jest fake timers do not work (timeout) and are commented out
  • jest.config.js needs polishing (copy config from core)
  • types from core has to be removed in favor of new defition files from core (after core is in TS)
  • ClientPageRenderer and LegacyClientPageRenderer has to be removed from index.ts and compiled separately

This issue will be updated as new fixes/features are merged to next or new issues are discovered.

@jsimck
Copy link
Contributor Author

jsimck commented Jan 29, 2023

Most issues have been resolved, others are outdated.

@jsimck jsimck closed this as completed Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment