Skip to content

Latest commit

 

History

History
144 lines (94 loc) · 6.07 KB

CONTRIBUTING.md

File metadata and controls

144 lines (94 loc) · 6.07 KB
Raw

Contributing

Please see our community docs on contributing.

This document is for developers/designers contributing to source code. If you're interested in contributing a different way, please see the link above.

Requirements

Structure

santlipi
├── build
│   └── qa
├── packages
│   ├── npm
│   └── pubdev
├── scripts
│   ├── mustache
│   ├── tests
│   ├── build.py
│   ├── constants.py
│   ├── make.py
│   └── qa.py
├── sources
│   └── SantLipi.glyphs
├── pyproject.toml
└── README.md

The majority of the build folder is generated with the script files in scripts. These generating scripts are referenced for python runners in pyproject.toml under the [project.scripts] section.

Config files for the Sant Lipi distributions are found in the packages folder.

The sources folder contains the actual font file. A specific font editor Glyphs 3 is required to open it. However there is a way to convert the Glyphs source file to UFOs using Google's glyphsLib.

The pyproject.toml file can be used to track dependencies and run scripts. See below for typical uses:

pip

Starting with Python 3.4, pip is included by default. The following will create a virtual environment, install the dependencies, and then run a script listed in pyproject.toml under the [project.scripts] section.

python3 -m venv .venv
source .venv/bin/activate
python3 -m pip install .
build

Hatch

On the other hand, Hatch will automatically do all of the above for you in a single command. Learn more at hatch.pypa.io.

hatch run build

Run QA (Quality Assurance)

QA against the latest version is available using the online Sant Lipi Test Suite.

If you wish to run QA locally against your local Sant Lipi:

  • Run the qa script.
  • Open build/index.html in a web browser.

Add Tests to QA

  • Edit scripts/tests.py.
  • Run QA to verify tests.

Modify/Change Font

  • Use Glyphs 3 to open sources/SantLipi.glyphs.
  • Run QA locally to confirm changes.

Open Pull Requests

Role: contributors wishing to change the project source code

  • Fork this repository
  • Create a branch from main
  • Make any changes
  • Submit a pull request

Note: Before creating new branches, ensuring that the forked main is up to date with the upstream/original main will ease workflow.

Merge PRs

Role: project authors/maintainers

  • Pull requests should be squashed or rebased.
  • Commit messages on main branch should generally conform to Conventional Commits 1.0.0.
  • No commit's type should be fix.

Note

OpenType specifications only allow for a "Major" and "Minor" version. There is no "Patch" version number. In Sant Lipi packages, the patch number should always be 0. The minor version in Glyphs should be 3 digits long (e.g. SemVer 0.1.0 becomes Version 0.001, SemVer 2.15.0 becomes Version 2.015). Minor version should not exceed 999. If that ever happens, then should probably just bump the Major version number and reset Minor to 0. Installation software can use these version strings to compare font versions. Please adhere to these rules.

Types

Some types correlate with incrementing major, minor, and patch versions in Semantic Versioning. These types should only be used for code changes in the sources folder. (This folder is considered the project's API.)

  • BREAK increments major. To be used when making incompatible changes to the API. E.g. deleting glyphs from the font.
  • feat increments minor. To be used when adding backwards-compatible functionality to the API. E.g. changing metrics, shapes, features, etc.

Project authors/maintainers should never merge a PR whose commit(s) begin with fix, as there are no patch bumps for this project. See Note above.

All other types are ignored by the version bump workflow. These types are typically used outside the API folder, but may change API source code without actually affecting anything for the end user. Valid non-versioning (non-API related) types include: build, ci, docs, perf, refactor, revert, style, and test.

Release

Role: project authors/maintainers

See actions for workflows related to bumping version numbers, releasing to GitHub, and publishing packages.

Note: The entire release process can be completed on GitHub in a web browser.

1. Bump (Version Increment)

  • This workflow bumps/increments the version via a Pull Request.
  • The PR will list all the commit history from after the last release.
  • It is a good idea to modify the CHANGELOG.md in the PR.
  • The PR needs to be merged prior to publishing.

Note: Leave the override field blank for automatic versioning. If the PR that is opened bumps incorrectly, it is always possible to close the automatic PR and manually bump a new workflow.

Note: If manually overriding the version bump, remember to use 0 for the patch version number.

2. Release

  • This workflow should immediately follow a version increment/bump PR merge.
  • This workflow will create a GitHub release.
  • The tag and title of the release will say "prerelease" on purpose.

3. Publish

  • This workflow is automatically triggered when pushing a git tag to the repo. A GH action is not able to trigger these conditions; Git tags must be pushed by an admin/user with write permissions.
  • Edit the latest release. At the top left click the "tag" dropdown. Create a new tag by omitting -prerelease.
  • Finish by submitting the form "Update release". This will automatically trigger the publish workflow.
  • Optionally go to tags and delete the prerelease tag, which should only have a zip/tar.gz associated with it.