Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The double ਡੰਡਾ/ਹੱਦ character (॥) should join with non-numeral characters that appear before/after it #53

Open
irvanjitsingh opened this issue Dec 6, 2023 · 5 comments
Labels
□ Type Story New feature or enhancement

Comments

@irvanjitsingh
Copy link

Persona

Developer/Vidhiarthi

Goal

use this font and promote an accurate representation of gurmukhi

Motivation

purataan hathlikhat saroops use the ॥ character in this manner

Acceptance Criteria

No response

Approach

No response

Mockup

No response

@irvanjitsingh irvanjitsingh added the □ Type Story New feature or enhancement label Dec 6, 2023
@bhajneet
Copy link
Member

bhajneet commented Dec 6, 2023

Very cool idea! Also doable. Unfortunately it will take a backseat to a lot of the other work across our projects. Going to leave this issue open in case anyone else feels like working on it.

Ideas:

  • Implement using style font feature
  • add component for connecting

What also would help is if you can share lots of pictures of the different ways this shows up! Thank you for opening your first issue with us

@irvanjitsingh
Copy link
Author

Attached some screenshots from a personal project where I've used one of the spacing characters in the private-use section of the Akaash font by Dr Kulbir S Thind and manipulated element margins with CSS to achieve the same result.

Screen Shot 2023-12-06 at 11 03 53 PM Screen Shot 2023-12-06 at 11 03 03 PM

I've attached 3 screenshots of puratan saroops

  1. aad saroop, baba deep singh jee likhat 'sunehri saroop'
  2. aad saroop, 1714, from gurmatveechar
  3. dasam saroop, from gurmatveechar
Screen Shot 2023-12-06 at 11 02 30 PM Screen Shot 2023-12-06 at 11 01 51 PM Screen Shot 2023-12-06 at 11 00 52 PM

Aside: I intentionally took screens from the first ang of these saroops to also highlight that the ਕਾਰ ਚਿਨ (symbol) in ਿੲਕ ਓਅੰਕਾਰ is clearly shaped in an arch, similar to how Akaash, GurbaniAkhar, Anmol, Mukta Mahee, and almost every other popular font has it, but contrary to what SantLipi is using. I understand that there is debate about this but would ask that the team use the original style of the glyph as the default and provide the modified style as an alternative, similar to what is being done for yakash, as that would be a more faithful representation of gurmukhi as written in puratan saroops of SGGSJ. Akaash has an alternative, larger symbol composed of two glyphs in the private-use set (refer to the screenshot) that can be used if there is more space. SantLipi could implement something similar, while also including the style that you currently have as yet an alternative if anyone wants to use it.

@bhajneet
Copy link
Member

bhajneet commented Dec 7, 2023

Wow that's awesome, thank you for sharing!

I understand that there is debate about this but would ask that the team use the original style of the glyph as the default and provide the modified style as an alternative

Would you care to please elaborate on this. That way the information will be available in a public forum. Since you're the only one to share the info, it would be nice if you can provide insights on both sides of the argument and why you believe one side should be set as the default over the other!

On a general level it would also be nice to know why these stylistic changes matter so much to you and perhaps some others! What effect do style specifics have on you?

Very interesting dialogue so far! Thank you

@irvanjitsingh
Copy link
Author

I think it might be best to continue this conversation in another thread, and leave this one for the dandiyan. I'll open another issue about IkOangKaar.

@bhajneet
Copy link
Member

@irvanjitsingh as you didn't open a new issue, I figured to respond here. You can view the latest version of Sant Lipi online at https://shabados.github.io/SantLipi/qa/test/words-from-nitnem.html Note the ੴ

I'd like to move towards finalizing this font. I have a few more things left to do on my end. And I don't see this issue as a blocker to the next major version (and I would like to add support for this feature in a post-v1.0.0 release).

Do you see any other issues / concerns before going for a v1 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
□ Type Story New feature or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants