Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update toShahmukhi with appropriate end of character transliteration #180

Open
Harjot1Singh opened this issue Nov 3, 2020 · 0 comments
Open

Update toShahmukhi with appropriate end of character transliteration #180

Harjot1Singh opened this issue Nov 3, 2020 · 0 comments
Assignees
@sarabveer
Labels
Effort 1 Simple task (code/non-code). Impacts Few Does not affect many end-users. ○ Type Bug Regressions/production issues that do not function as intended.

Comments

@Harjot1Singh
Copy link
Member

gurmukhi-utils/lib/toShahmukhi.js

Line 108 in f0a2bfa

[ new RegExp( `(\\S[^ਹ])([ਿੁ])([\\s$${vishraams.join( '' )}])`, 'ug' ), '$1$3' ], // Remove trailing ੁ and ਿ except when on ਹ or on a standalone akhar

This would also need to be updated.

Perhaps best to open a new issue for you to work on, I don't know how to fix the tests on this

image

Please allow this PR to be merged in for the time being

Originally posted by @bhajneet in #177 (comment)
@Harjot1Singh Harjot1Singh added Effort 1 Simple task (code/non-code). Impacts Few Does not affect many end-users. Status: To Do ○ Type Bug Regressions/production issues that do not function as intended. labels Nov 3, 2020
@Harjot1Singh Harjot1Singh mentioned this issue Nov 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarabveer sarabveer

Labels
Effort 1 Simple task (code/non-code). Impacts Few Does not affect many end-users. ○ Type Bug Regressions/production issues that do not function as intended.
Projects
Project Management
Status: Triage
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Harjot1Singh @sarabveer @bhajneet