Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correctly themed launch screen #190

Open
bhajneet opened this issue Dec 11, 2021 · 0 comments
Open

Use correctly themed launch screen #190

bhajneet opened this issue Dec 11, 2021 · 0 comments
Labels
Effort 2 Well-sized task (simple code + tests). □ Type Story Feature or requirement written from the user's perspective using non-technical language.

Comments

@bhajneet
Copy link
Member

bhajneet commented Dec 11, 2021

User Persona, Goal, and Motivation

I am a dark mode user, I want to open shabad os without a flash, so that I can avoid blinding my eyes.

Acceptance Criteria

Do below AC for light theme and dark theme:

  • GIVEN app is not open in memory
  • WHEN user opens app
  • THEN make sure the splash screen's background matches the app theme's main view bg color

Be sure to do above for both light+dark themes

Approach

Generate images via Fastlane appicon plugin - need to figure out if/how to make it work properly, otherwise use appicon generator online. Should have logo and should have dark and light mode variants - might be that we just supply a transparent image and it uses the OS primary colour..

Mockup

This is the issue right now, not what we want to emulate:

RPReplay_Final1639254715.MP4
@bhajneet bhajneet added the □ Type Story Feature or requirement written from the user's perspective using non-technical language. label Dec 11, 2021
@Harjot1Singh Harjot1Singh changed the title Use correctly themed splash screen Use correctly themed launch screen Jan 16, 2022
@Harjot1Singh Harjot1Singh added the Effort 2 Well-sized task (simple code + tests). label Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort 2 Well-sized task (simple code + tests). □ Type Story Feature or requirement written from the user's perspective using non-technical language.
Projects
Status: Ready for Development
Development

No branches or pull requests

2 participants