forked from shaka-project/triage-party-config
/
shaka-triage-party-config.yaml
375 lines (308 loc) · 11.7 KB
/
shaka-triage-party-config.yaml
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
# Shaka Team Triage Party - Config
# Copyright 2021 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# Uses Shaka team's common label structure defined in
# go/shaka-github-labels-design
settings:
name: Shaka Team Triage
repos:
# TODO: re-enable Shaka Packager when we are ready to catch up
#- https://github.com/google/shaka-packager
- https://github.com/google/shaka-player
# TODO: re-enable Shaka Player Embedded when we are ready to catch up
#- https://github.com/google/shaka-player-embedded
- https://github.com/google/shaka-streamer
- https://github.com/google/eme-encryption-scheme-polyfill
- https://github.com/google/generic-webdriver-server
- https://github.com/joeyparrish/static-ffmpeg-binaries
# From 0-1, how similar issues must be to be tagged as "similar"
min_similarity: 0.75
# Which roles are considered members of the project?
member-roles:
# TODO: enable "member" when we have our own org for these projects
#- member # of the org that owns the project
- collaborator
- owner
# Hard-coded "members" of the team, who do not fit into member-roles above.
members: []
collections:
- id: triage
name: Daily Triage
description: |
Please address these groups of issues in this order.
rules:
- issue-needs-type
- issue-needs-priority
- question-needs-answer
# TODO: It may be nice to add components to everything down the line.
# For now, it's not critical, and there's a huge backlog.
#- issue-needs-component
- id: pr
name: PRs
dedup: true
description: |
Help them help us!
Please give attention to these PRs. Treat contributors like teammates.
rules:
- pr-ready-to-merge
- pr-needs-review
- id: bugs
name: Bugs
dedup: true
description: |
"To create bugs is human; to fix them, divine."
Please address these groups of issues in this order.
rules:
- assigned-issues
- unassigned-p0-issues
- unassigned-p1-issues
- unassigned-p2-issues
- unassigned-p3-issues
- unassigned-p4-issues
- id: cleanup
name: Weekly Cleanup
dedup: true
description: |
A clean tracker is a happy tracker!
Please check these issues that may need to be cleaned up.
rules:
- issues-maybe-ready-to-close
- announcements
- id: __open__
name: All open PRs and issues that should be considered for repository stats (hidden)
used_for_statistics: true
hidden: true
rules:
- open-prs
- open-issues
- id: __velocity__
name: Issues to include in velocity metrics (hidden)
# To see issue velocity averaged over the last 90 days, see the banner at
# https://triage-party.shakalab.rocks/k/__velocity__
# TODO: Expose/track this data some other way. This is not easy.
used_for_statistics: true
hidden: true
rules:
- recently-closed-milestone-issues
# A long bit of text, factored out and re-used in the rules below.
bug-resolution-text: &bug-resolution-text |
Fix bugs! This is the "fun" part.
1. Try to reproduce the issue. Some options for repro:
• Use the demo's "custom content" tab
• Write a new unit or integration test to simulate the scenario in the report
• This lets you run tests in the lab on non-desktop browsers
2. If the issue cannot be reproduced, set "status: unable to reproduce"
3. Once the issue can be reproduced, try to fix it or assign it to someone who can
rules:
issue-needs-type:
name: "Untyped Issues"
resolution: |
Please add a type label.
(You do not need to reproduce the issue yet. At this stage, assume that bug reports are correct.)
type: issue
filters:
# Has no type
- label: "!type: .*"
# And no status (open issues with a status show up in the cleanup tab)
- label: "!status: .*"
issue-needs-priority:
name: "Unprioritized Issues"
resolution: |
Please add a priority label.
(Make an initial assessment. It doesn't have to be perfect.)
Tips for assessing priority:
• If it's an enhancement, it is almost always a P2 or lower
• If it's a bug, it is usually a P1 or P2
• Read the descriptions of each priority label on GitHub to help you decide
type: issue
filters:
- label: "!priority: .*"
# Has a type...
- label: "type: .*"
# But not one of these, which do not need priorities.
- label: "!type: (announcement|external|process|question)"
# And if it already has a status, it doesn't need a priority.
- label: "!status: .*"
issue-needs-component:
name: "Issues without a Component"
resolution: |
Please add at least one component label.
(Make an initial assessment. It doesn't have to be perfect.)
type: issue
filters:
- label: "!component: .*"
# Has a type...
- label: "type: .*"
# But not one of these, which do not need components.
- label: "!type: (announcement|CI|code health|docs|external|process|question)"
question-needs-answer:
name: "Unanswered questions"
resolution: |
Please answer as best you can.
You may ping your teammates if you need help finding information, but
try to be the one to track down that info and leave the answer on
GitHub. Every answer you dig up for someone else is one more thing
you've learned for yourself.
type: issue
filters:
- label: "type: question"
# The most recent comment was not from a member of the project.
- tag: "!(member-last|owner-last|collaborator-last)"
# We didn't apply the "waiting on response" label manually.
- label: "!status: waiting on response"
pr-ready-to-merge:
name: "PRs ready to merge"
resolution: |
Please check if these PRs can be merged.
Make sure all checks have passed and that a team member or other
appropriate reviewer has approved the PR.
type: pull_request
filters:
# TODO: test these filters on PRs from project members/owners
# Match all approved PRs. But this could be approval from anyone, so
# extra scrutiny may be required.
- tag: "approved"
# TODO: add labels for checks (Jenkins and/or GitHub Actions)
# TODO: split this into PRs that have passed checks and those that haven't
pr-needs-review:
name: "PRs ready for review"
resolution: |
Please review.
You may ping your teammates if you need help evaluating a PR, but try
to track down what you don't know.
You should also consider asking the author to clarify things for you,
either in review comments or by adding comments to their code.
You can manually add the "status: waiting for response" label if you
haven't had a reply in a while. This will start the timer for
shaka-bot to eventually close the PR.
If you aren't getting replies to your feedback, you can also choose to
re-implement what the contributor has sent in a different way. But do
not copy their code and merge it as your own, as this would strip the
original author of credit for their work.
If you want to keep the original implementation, but make small changes
to it, you can edit the PR before merging it:
1. Go to the "Files changed" tab of the PR
2. Click the overflow menu on the right side of the diff
3. Click "Edit file"
4. Leave comments in the PR to explain your change to the author
type: pull_request
filters:
# TODO: test these filters on PRs from project members/owners
# The PR has new commits since the last member response (new-commits), or
# the author has responded more recently than any member of the project
# (recv or recv-q), or the PR has not been reviewed (unreviewed).
- tag: "(new-commits|recv|recv-q|unreviewed)"
# In this category, only match PRs which have not been approved yet.
- tag: "!approved"
assigned-issues:
name: "Assigned issues"
resolution: |
These issues are already assigned to someone.
Is the issue assigned to you? If there's nothing more urgent, try to
finish what you started.
Is the issue assigned to someone else? Are they actually working on it?
Ask them if they are still engaged on the issue, and unassign it if they
are not.
type: issue
filters:
- label: "!type: (enhancement|external)"
- label: "!status: .*"
- tag: "assigned"
unassigned-p0-issues:
name: "Unassigned P0 issues"
resolution: *bug-resolution-text
type: issue
filters:
- label: "!type: (enhancement|external)"
- label: "priority: P0"
- label: "!status: .*"
- tag: "!assigned"
unassigned-p1-issues:
name: "Unassigned P1 issues"
resolution: *bug-resolution-text
type: issue
filters:
- label: "!type: (enhancement|external)"
- label: "priority: P1"
- label: "!status: .*"
- tag: "!assigned"
unassigned-p2-issues:
name: "Unassigned P2 issues"
resolution: *bug-resolution-text
type: issue
filters:
- label: "!type: (enhancement|external)"
- label: "priority: P2"
- label: "!status: .*"
- tag: "!assigned"
unassigned-p3-issues:
name: "Unassigned P3 issues"
resolution: *bug-resolution-text
type: issue
filters:
- label: "!type: (enhancement|external)"
- label: "priority: P3"
- label: "!status: .*"
- tag: "!assigned"
unassigned-p4-issues:
name: "Unassigned P4 issues"
resolution: *bug-resolution-text
type: issue
filters:
- label: "!type: (enhancement|external)"
- label: "priority: P4"
- label: "!status: .*"
- tag: "!assigned"
issues-maybe-ready-to-close:
name: "Issues that might be ready to close"
resolution: |
Please check if the issue should be closed. Use your best judgement.
Possible outcomes:
• Remove the status, if it's wrong
• Leave open for further discussion or consideration, if we're not sure
• Close, referencing the status
type: issue
filters:
# Has a status...
- label: "status: .*"
# But not one of these. Any other status label is usually followed by
# closing an issue (eventually). So once in a while, we should check to
# see if it's time to close these issues.
- label: "!status: (archived|waiting on response)"
# TODO: Add multiple-types to the weekly list once there is a way to do it.
# See https://github.com/google/triage-party/issues/274
#multiple-types:
# name: "Issues with more than one type"
# resolution: "Choose a specific type for this issue."
# type: issue
# filters:
announcements:
name: "Announcements"
resolution: "Please close if the announcement is no longer relevant."
type: issue
filters:
- label: "type: announcement"
open-issues:
name: "Open Issues"
type: issue
open-prs:
name: "Open PRs"
type: pull_request
recently-closed-milestone-issues:
name: "Recently closed milestone issues"
type: issue
filters:
- state: closed
- closed: -90d
- milestone: ".*"