Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using named pipes for manifests #1209

Open
duggaraju opened this issue May 26, 2023 · 1 comment
Open

Support using named pipes for manifests #1209

duggaraju opened this issue May 26, 2023 · 1 comment
Labels
component: DASH The issue involves DASH output flag: good first issue This might be a relatively easy issue; good for new contributors flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this

Comments

@duggaraju
Copy link
Contributor

System info

Operating System: Any
Shaka Packager Version: v2.6.1-634af65-release

Issue and steps to reproduce the problem

Try running a shaka command line with using a named pipe for the manifest name.

Packager Command:

Extra steps to reproduce the problem?
shaka writes the manifest to a temporary file and then renames. This would break the pipe.
When creating VOD content where manifest is written once at the end, can we avoid the rename and directly write to output to make it work with pipes?

What is the expected result?
the operation succeeds.

What happens instead?

The operation fails because the pipe is deleted during the rename. Also on windows named pipes are under \.\pipe directory so can't create a temporary file there.

@duggaraju
Copy link
Contributor Author

On further investigation this issue seems to be specific to dash manifest. HLS manifests can be written to a pipe without issues.

@cosmin cosmin added flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this component: DASH The issue involves DASH output flag: good first issue This might be a relatively easy issue; good for new contributors labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DASH The issue involves DASH output flag: good first issue This might be a relatively easy issue; good for new contributors flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this
Projects
None yet
Development

No branches or pull requests

2 participants