Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTML subtitles - ttp:tickRate is ignored #3009

Closed
Karmel0x opened this issue Nov 25, 2020 · 3 comments · Fixed by #3864 or #4009
Closed

TTML subtitles - ttp:tickRate is ignored #3009

Karmel0x opened this issue Nov 25, 2020 · 3 comments · Fixed by #3864 or #4009
Labels
component: captions/subtitles The issue involves captions or subtitles component: TTML The issue involves TTML subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@Karmel0x
Copy link

Karmel0x commented Nov 25, 2020

Have you read the FAQ and checked for duplicate open issues?
yes

What version of Shaka Player are you using?
3.0.6 (latest) release and master

Can you reproduce the issue with our latest release version?
yes

Can you reproduce the issue with the latest code from master?
yes

Are you using the demo app or your own custom app?
both

If custom app, can you reproduce the issue using our demo app?
yes

What browser and OS are you using?
Firefox 83.0 (latest) / Chrome 87.0 (latest)

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?
https://gist.githubusercontent.com/Karmel0x/fc4b648a69ca999a3a2e3ae3c3fd914e/raw/c2df87918308bcf5dbd0d9b225242c7cf4fd8208/wwww.mpd

What did you do?
Go to this link and choose english captions: demo link

What did you expect to happen?
(subtitles link) tickRate is set to 10, subtitles are on 10t and 30t
so subtitles should appear on 1 second and 3 second

What actually happened?
Subtitles appears on 10 second and 30 second

@TheModMaker TheModMaker added component: captions/subtitles The issue involves captions or subtitles type: enhancement New feature or request component: TTML The issue involves TTML subtitles specifically and removed needs triage labels Dec 1, 2020
@TheModMaker TheModMaker added this to the Backlog milestone Dec 1, 2020
@Karmel0x
Copy link
Author

Karmel0x commented Jul 12, 2021

Probably it's bad solution but it's fixing the problem using this trick:

At /lib/text/ttml_text_parser.js#L87 insert this piece of code:

ttpNs = tt.attributes.find(element => element.value.indexOf('#parameter') != -1)?.value || ttpNs;

@joeyparrish
Copy link
Member

It seems that the root cause is your TTML using a different namespace URI than what we are expecting. Can you give us any context on that?

If you load the namespace URIs in your browser, you'll see the following:

https://www.w3.org/ns/ttml/

This is a placeholder for a namespace document that permits dereferencing the Timed Text Markup Language (TTML) 1.0 namespace URIs:

...

This namespace is stable!

https://www.w3.org/2006/10/ttaf1/

This is a placeholder for a namespace document that permits dereferencing the Timed Text (TT) Authoring Format V1.0 Distribution Format Exchange Profile namespace URIs:

...

This namespace is not stable!

Is TTAF a predecessor to TTML?

@joeyparrish joeyparrish added the priority: P2 Smaller impact or easy workaround label Jul 12, 2021
@Karmel0x
Copy link
Author

Karmel0x commented Jul 13, 2021

I've already provided links, demo, manifest and subtitles.
Subtitles are ttaf1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles component: TTML The issue involves TTML subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
5 participants