Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Add quality selection for audio-only content #3649

Merged
merged 1 commit into from Apr 21, 2022

Conversation

nbcl
Copy link
Contributor

@nbcl nbcl commented Sep 20, 2021

The present pull request aims to provide a solution to #2071 (Quality selection UI for audio-only content) by replacing the resolution selection menu with a quality selection menu in audio-only content.

Fixes: #2071

How to preview

Initialize the client with a config that contains quality in the controlPanelElements and load the player with an audio-only manifest.

const config = {
 'controlPanelElements': ['quality'],
}
ui.configure(config);

await player.load('https://storage.googleapis.com/shaka-demo-assets/dig-the-uke-clear/dash.mpd');

Changelog

test/ui/ui_integration.js

Removes the integration test that checks for a hidden resolution button in audio-only content.

test/ui/ui_unit.js

Expects the correct version of the resolution button and appropriate bandwidth parsing for an audio-only manifest.

ui/locales/en.json

Adds the quality locale as reference in English.

ui/locales/source.json

Adds a description and meaning for the quality locale.

ui/resolution_selection.js

Removes TODO fix that hid resolution button for audio-only content by adding the removal of duplicates, sorting and naming of available tracks flows for either video or audio-only content.

Replaces resolution menu with audio quality menu when content is audio-only.
@joeyparrish joeyparrish merged commit adc3502 into shaka-project:main Apr 21, 2022
joeyparrish added a commit to joeyparrish/shaka-player that referenced this pull request Apr 21, 2022
@avelad avelad added this to the v4.0 milestone May 4, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quality selection UI for audio-only content
4 participants