Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TTML - font-size is not applied in nested cues #3743

Closed
avelad opened this issue Nov 4, 2021 · 0 comments · Fixed by #3837 or #4009
Closed

TTML - font-size is not applied in nested cues #3743

avelad opened this issue Nov 4, 2021 · 0 comments · Fixed by #3837 or #4009
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.0

Comments

@avelad
Copy link
Collaborator

avelad commented Nov 4, 2021

Have you read the FAQ and checked for duplicate open issues? Yes

What version of Shaka Player are you using? 3.2.1

Can you reproduce the issue with our latest release version? Yes

Can you reproduce the issue with the latest code from master? Yes

Are you using the demo app or your own custom app? Custom app

If custom app, can you reproduce the issue using our demo app? yes

What browser and OS are you using?
Any with MSE support

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

I can't share the failing stream, but I can share the subtitle file that renders badly.

<?xml version="1.0" encoding="utf-8"?>
<tt xml:lang="en" xmlns="http://www.w3.org/ns/ttml" xmlns:ttm="http://www.w3.org/ns/ttml#metadata" xmlns:tts="http://www.w3.org/ns/ttml#styling">
  <head>
    <metadata>
      <ttm:title/>
      <ttm:desc/>
      <ttm:copyright/>
    </metadata>
    <styling>
      <style tts:backgroundColor="rgba(0,0,0,100)" tts:displayAlign="center" tts:extent="80% 10%" tts:fontFamily="proportionalSansSerif" tts:fontSize="16px" tts:origin="10% 85%" tts:textAlign="center" xml:id="backgroundStyle"/>
      <style style="backgroundStyle" tts:backgroundColor="transparent" tts:color="white" xml:id="speakerStyle"/>
    </styling>
    <layout>
      <region style="speakerStyle" tts:zIndex="1" xml:id="speaker"/>
      <region style="backgroundStyle" tts:zIndex="0" xml:id="background"/>
    </layout>
  </head>
  <body>
    <div style="default" xml:lang="en">
      <p begin="00:43:03.310" end="00:43:04.723" region="speaker">Chris Gardner.</p>
      <p begin="00:43:05.378" end="00:43:07.344" region="speaker">¿Qué tal? Buenos días.</p>
      <p begin="00:43:07.516" end="00:43:09.103" region="speaker">Chris Gardner.</p>
      <p begin="00:43:09.620" end="00:43:11.654" region="speaker">Me alegra verlo de nuevo.</p>
      <p begin="00:43:12.000" end="00:43:13.964" region="speaker">Chris Gardner. Mucho gusto.</p>
      <p begin="00:43:15.688" end="00:43:18.447" region="speaker">Hace media hora
        <br/>
        que estoy sentado afuera,</p>
      <p begin="00:43:18.482" end="00:43:22.620" region="speaker">pensando en cómo explicarles
        <br/>
        por qué estoy vestido así.</p>
      <p begin="00:43:24.172" end="00:43:28.000" region="speaker">Y quería contarles algo
        <br/>
        que demostrara cualidades</p>
      <p begin="00:43:28.034" end="00:43:30.241" region="speaker">que seguramente admiran,</p>
      <p begin="00:43:30.275" end="00:43:32.861" region="speaker">como la seriedad,
        <br/>
        la perseverancia,</p>
      <p begin="00:43:32.895" end="00:43:35.068" region="speaker">el trabajo en equipo, no sé.</p>
      <p begin="00:43:35.620" end="00:43:37.688" region="speaker">Y no se me ocurrió nada.</p>
      <p begin="00:43:39.206" end="00:43:41.930" region="speaker">Así que la verdad es
        <br/>
        que me arrestaron,</p>
      <p begin="00:43:41.964" end="00:43:44.241" region="speaker">por no pagar
        <br/>
        las multas de tránsito.</p>
      <p begin="00:43:44.275" end="00:43:46.310" region="speaker">¿Multas de tránsito?</p>
      <p begin="00:43:46.585" end="00:43:49.723" region="speaker">Vine corriendo desde
        <br/>
        la comisaría de la calle Fulton.</p>
      <p begin="00:43:50.034" end="00:43:52.447" region="speaker">¿Qué estaba haciendo
        <br/>
        cuando lo arrestaron?</p>
      <p begin="00:43:52.482" end="00:43:55.000" region="speaker">Estaba pintando
        <br/>
        mi apartamento.</p>
      <p begin="00:43:55.620" end="00:43:57.068" region="speaker">¿Ya está seco?</p>
      <p begin="00:43:57.482" end="00:43:58.999" region="speaker">Eso espero.</p>
      <p begin="00:43:59.861" end="00:44:02.000" region="speaker">Jay dice
        <br/>
        que es muy decidido.</p>
    </div>
  </body>
</tt>

What configuration are you using? What is the output of player.getConfiguration()?

Default

What did you do?

Load the previous subtitle file

What did you expect to happen?
The font-size is consistley between cues

What actually happened?

Depending on the type of cue, the source defined in css is taken or the one of the TTML file is taken.

Grabacion.de.pantalla.2021-11-04.a.las.8.24.06.mp4
@avelad avelad added the type: bug Something isn't working correctly label Nov 4, 2021
@shaka-bot shaka-bot added this to the v3.3 milestone Nov 4, 2021
@theodab theodab added component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround labels Nov 11, 2021
@avelad avelad mentioned this issue Jan 10, 2022
Merged
theodab pushed a commit that referenced this issue Jan 12, 2022
fix(text): Made nested cues inherit region (#3837)
3ff48cb 
Closes #3743
joeyparrish pushed a commit that referenced this issue Jan 28, 2022
@joeyparrish
fix(text): Made nested cues inherit region (#3837)
814a3c8 
Closes #3743
joeyparrish pushed a commit that referenced this issue Jan 28, 2022
@joeyparrish
fix(text): Made nested cues inherit region (#3837)
b49e354 
Closes #3743
joeyparrish pushed a commit that referenced this issue Jan 28, 2022
@joeyparrish
fix(text): Made nested cues inherit region (#3837)
bc5fabe 
Closes #3743
@github-actions github-actions bot mentioned this issue Feb 12, 2022
Closed
@github-actions github-actions bot mentioned this issue Mar 3, 2022
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Mar 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2022
@avelad avelad modified the milestones: v3.3, v4.0 May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.0
3 participants
@avelad @shaka-bot @theodab