Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captions use the Entire screen #3745

Closed
FireMasterK opened this issue Nov 6, 2021 · 0 comments · Fixed by #3838 or #4009
Closed

Captions use the Entire screen #3745

FireMasterK opened this issue Nov 6, 2021 · 0 comments · Fixed by #3838 or #4009
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@FireMasterK
Copy link

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
3.2.1

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Not tried

Are you using the demo app or your own custom app?
Custom

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Linux, Brave

What are the manifest and license server URIs?
TTML File: https://bin.snopyta.org/?1517679bd5c2cddf#5861Y5KEE94RUY5LGFWNWu3AgLzBbdcquy74a2bYLvmQ

What configuration are you using? What is the output of player.getConfiguration()?
Demo Player / N/A

What did you do?
Run this in the JavaScript console, and select the captions track.

player = video.ui.getControls().getLocalPlayer();
player.addTextTrack('data:text/xml;charset=utf-8;base64,<?xml version="1.0" encoding="utf-8" ?>
<tt xml:lang="en" xmlns="http://www.w3.org/ns/ttml" xmlns:ttm="http://www.w3.org/ns/ttml#metadata" xmlns:tts="http://www.w3.org/ns/ttml#styling" xmlns:ttp="http://www.w3.org/ns/ttml#parameter" ttp:profile="http://www.w3.org/TR/profile/sdp-us" >
<head>
<styling>
<style xml:id="s1" tts:textAlign="center" tts:extent="90% 90%" tts:origin="5% 5%" tts:displayAlign="after"/>
<style xml:id="s2" tts:fontSize=".72c" tts:backgroundColor="black" tts:color="white"/>
</styling>
<layout>
<region xml:id="r1" style="s1"/>
</layout>
</head>
<body region="r1">
<div>
<p begin="00:00:01.514" end="00:00:04.597" style="s2">(upbeat disco music)</p>
<p begin="00:00:14.508" end="00:00:17.162" style="s2">♪ Well, you can tell by<br />the way I use my walk ♪</p>
<p begin="00:00:17.162" end="00:00:19.708" style="s2">♪ I&#39;m a woman&#39;s man, no time to talk ♪</p>
<p begin="00:00:19.708" end="00:00:21.932" style="s2">♪ Music loud and the women warm ♪</p>
<p begin="00:00:21.932" end="00:00:24.228" style="s2">♪ I&#39;ve been kicked<br />around since I was born ♪</p>
<p begin="00:00:24.228" end="00:00:26.802" style="s2">♪ And now it&#39;s all right, it&#39;s okay ♪</p>
<p begin="00:00:26.802" end="00:00:29.093" style="s2">♪ And you may look the other way ♪</p>
<p begin="00:00:29.093" end="00:00:31.351" style="s2">♪ But we can try to understand ♪</p>
<p begin="00:00:31.351" end="00:00:33.780" style="s2">♪ The New York Times&#39; effect on man ♪</p>
<p begin="00:00:33.780" end="00:00:35.920" style="s2">♪ Whether you&#39;re a brother<br />or whether you&#39;re a mother ♪</p>
<p begin="00:00:35.920" end="00:00:38.361" style="s2">♪ You&#39;re stayin&#39; alive, stayin&#39; alive ♪</p>
<p begin="00:00:38.361" end="00:00:40.581" style="s2">♪ Feel the city breakin&#39;<br />and everybody shakin&#39; ♪</p>
<p begin="00:00:40.581" end="00:00:43.122" style="s2">♪ And we&#39;re stayin&#39; alive, stayin&#39; alive ♪</p>
<p begin="00:00:43.122" end="00:00:47.755" style="s2">♪ Ah, ah, ah, ah, stayin&#39;<br />alive, stayin&#39; alive ♪</p>
<p begin="00:00:47.755" end="00:00:51.755" style="s2">♪ Ah, ha, ha, ha, stayin&#39; alive ♪</p>
<p begin="00:00:58.635" end="00:01:03.413" style="s2">♪ Oh, when you walk ♪</p>
<p begin="00:01:03.413" end="00:01:06.035" style="s2">♪ Well, now I get low and I get high ♪</p>
<p begin="00:01:06.035" end="00:01:08.488" style="s2">♪ And if I can&#39;t get<br />either, I really try ♪</p>
<p begin="00:01:08.488" end="00:01:10.650" style="s2">♪ Got the wings of heaven on my shoes ♪</p>
<p begin="00:01:10.650" end="00:01:13.092" style="s2">♪ I&#39;m a dancin&#39; man,<br />and I just can&#39;t lose ♪</p>
<p begin="00:01:13.092" end="00:01:15.648" style="s2">♪ You know, it&#39;s all right, it&#39;s okay ♪</p>
<p begin="00:01:15.648" end="00:01:17.883" style="s2">♪ I&#39;ll live to see another day ♪</p>
<p begin="00:01:17.883" end="00:01:20.137" style="s2">♪ We can try to understand ♪</p>
<p begin="00:01:20.137" end="00:01:22.532" style="s2">♪ The New York Times&#39; effect on man ♪</p>
<p begin="00:01:22.532" end="00:01:24.607" style="s2">♪ Whether you&#39;re a brother<br />or whether you&#39;re a mother ♪</p>
<p begin="00:01:24.607" end="00:01:27.226" style="s2">♪ You&#39;re stayin&#39; alive, stayin&#39; alive ♪</p>
<p begin="00:01:27.226" end="00:01:29.344" style="s2">♪ Feel the city breakin&#39;<br />and everybody shakin&#39; ♪</p>
<p begin="00:01:29.344" end="00:01:31.834" style="s2">♪ And we&#39;re stayin&#39; alive, stayin&#39; alive ♪</p>
<p begin="00:01:31.834" end="00:01:36.530" style="s2">♪ Ah, ah, ah, ah, stayin&#39;<br />alive, stayin&#39; alive ♪</p>
<p begin="00:01:36.530" end="00:01:40.530" style="s2">♪ Ah, ah, ah, ah, stayin&#39; alive ♪</p>
<p begin="00:01:46.658" end="00:01:51.658" style="s2">♪ Oh ♪</p>
<p begin="00:01:53.052" end="00:01:58.052" style="s2">♪ Life going nowhere, somebody help me ♪</p>
<p begin="00:01:58.404" end="00:02:03.404" style="s2">♪ Somebody help me, yeah ♪</p>
<p begin="00:02:04.634" end="00:02:09.634" style="s2">♪ Life going nowhere,<br />somebody help me, yeah ♪</p>
<p begin="00:02:10.513" end="00:02:15.219" style="s2">♪ I&#39;m stayin&#39; alive ♪</p>
<p begin="00:02:15.219" end="00:02:17.909" style="s2">♪ Well, you can tell by<br />the way I use my walk ♪</p>
<p begin="00:02:17.909" end="00:02:20.610" style="s2">♪ I&#39;m a woman&#39;s man, no time to talk ♪</p>
<p begin="00:02:20.610" end="00:02:22.522" style="s2">♪ Music loud and women warm ♪</p>
<p begin="00:02:22.522" end="00:02:24.909" style="s2">♪ I&#39;ve been kicked<br />around since I was born ♪</p>
<p begin="00:02:24.909" end="00:02:27.567" style="s2">♪ But now it&#39;s all right, that&#39;s okay ♪</p>
<p begin="00:02:27.567" end="00:02:29.888" style="s2">♪ You may look the other way ♪</p>
<p begin="00:02:29.888" end="00:02:32.089" style="s2">♪ We can try to understand ♪</p>
<p begin="00:02:32.089" end="00:02:34.586" style="s2">♪ The New York Times&#39; effect on man ♪</p>
<p begin="00:02:34.586" end="00:02:36.741" style="s2">♪ Whether you&#39;re a brother<br />or whether you&#39;re a mother ♪</p>
<p begin="00:02:36.741" end="00:02:39.012" style="s2">♪ You&#39;re stayin&#39; alive, stayin&#39; alive ♪</p>
<p begin="00:02:39.012" end="00:02:41.162" style="s2">♪ Feel the city breakin&#39;<br />and everybody shakin&#39; ♪</p>
<p begin="00:02:41.162" end="00:02:43.776" style="s2">♪ And we&#39;re stayin&#39; alive, stayin&#39; alive ♪</p>
<p begin="00:02:43.776" end="00:02:48.407" style="s2">♪ Ah, ah, ah, ah, stayin&#39;<br />alive, stayin&#39; alive ♪</p>
<p begin="00:02:48.407" end="00:02:52.407" style="s2">♪ Ah, ah, ah, ah, stayin&#39; alive ♪</p>
<p begin="00:03:05.026" end="00:03:10.026" style="s2">♪ Life going nowhere, somebody help me ♪</p>
<p begin="00:03:10.292" end="00:03:15.292" style="s2">♪ Somebody help me, yeah ♪</p>
<p begin="00:03:16.628" end="00:03:21.628" style="s2">♪ Life going nowhere,<br />somebody help me, yeah ♪</p>
<p begin="00:03:22.368" end="00:03:27.368" style="s2">♪ I&#39;m stayin&#39; alive ♪</p>
<p begin="00:03:30.492" end="00:03:35.492" style="s2">♪ Life going nowhere, somebody help me ♪</p>
<p begin="00:03:35.783" end="00:03:40.783" style="s2">♪ Somebody help me, yeah ♪</p>
<p begin="00:03:42.071" end="00:03:47.071" style="s2">♪ Life going nowhere,<br />somebody help me, yeah ♪</p>
<p begin="00:03:47.891" end="00:03:52.891" style="s2">♪ I&#39;m stayin&#39; alive ♪</p>
<p begin="00:03:56.117" end="00:04:01.117" style="s2">♪ Life going nowhere, somebody help me ♪</p>
<p begin="00:04:01.302" end="00:04:04.719" style="s2">♪ Somebody help me, yeah ♪</p>
</div>
</body>
</tt>', 'xx', 'caption', 'application/ttml+xml');

What did you expect to happen?
When the captions are over one line, they don't take up the entire player space.

What actually happened?
image

@FireMasterK FireMasterK added the type: bug Something isn't working correctly label Nov 6, 2021
@shaka-bot shaka-bot added this to the v3.3 milestone Nov 6, 2021
@theodab theodab added component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround labels Nov 11, 2021
theodab pushed a commit that referenced this issue Jan 10, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Mar 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
@avelad avelad modified the milestones: v3.3, v4.0 May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
4 participants