Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TTML - font-size is not applied in nested cues #3837

Merged
merged 3 commits into from Jan 12, 2022

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Jan 10, 2022

Fixes: #3743

@avelad

This comment has been minimized.

lib/text/ttml_text_parser.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab January 12, 2022 09:04
@theodab
Copy link
Collaborator

theodab commented Jan 12, 2022

I'm not "authorized" to merge this pull request, huh.

@joeyparrish
Copy link
Member

Sorry, the new settings clearly need some work. Let me see if I can fix it.

@joeyparrish
Copy link
Member

@theodab, see if you can do it now. I think I fixed the settings.

@theodab
Copy link
Collaborator

theodab commented Jan 12, 2022

Thanks, that worked.

@theodab theodab merged commit 3ff48cb into shaka-project:master Jan 12, 2022
@avelad avelad deleted the style-nested-cues branch January 13, 2022 06:32
joeyparrish pushed a commit that referenced this pull request Jan 28, 2022
joeyparrish pushed a commit that referenced this pull request Jan 28, 2022
joeyparrish pushed a commit that referenced this pull request Jan 28, 2022
@avelad avelad added this to the v4.0 milestone May 4, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TTML - font-size is not applied in nested cues
3 participants