Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player fails without MediaCapabilities polyfill since v3.2.1 #3843

Closed
joeyparrish opened this issue Jan 10, 2022 · 0 comments
Closed

Player fails without MediaCapabilities polyfill since v3.2.1 #3843

joeyparrish opened this issue Jan 10, 2022 · 0 comments
Assignees
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@joeyparrish
Copy link
Member

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
v3.2.1, v3.2.2, v3.3.0

Can you reproduce the issue with our latest release version?
yes

Can you reproduce the issue with the latest code from master?
yes

Are you using the demo app or your own custom app?
custom

If custom app, can you reproduce the issue using our demo app?
N/A: demo app always installs polyfills

What browser and OS are you using?
any

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?

Any

What configuration are you using? What is the output of player.getConfiguration()?

N/A

What did you do?

If polyfills are not installed (or if the MediaCapabilities polyfill specifically is not installed), playback fails with CONTENT_UNSUPPORTED_BY_BROWSER. This is because the polyfill creates a workaround for #3530 at window.shakaMediaCapabilities, and the rest of the code expects that to always exist.

What did you expect to happen?
On platforms that have all the necessary APIs, polyfills should not be required.

What actually happened?

Without installing at least this one polyfill, Shaka Player v3.2.1, v3.2.2, and v3.3.0 are unusable.

See also #3696

@joeyparrish joeyparrish added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release labels Jan 10, 2022
@joeyparrish joeyparrish self-assigned this Jan 10, 2022
@shaka-bot shaka-bot added this to the v3.3 milestone Jan 10, 2022
joeyparrish added a commit that referenced this issue Jan 11, 2022
Revert "fix: Work around override of MediaCapabilities polyfill in Apple browsers (#3668)"

This reverts commit 31c0cd4.

Fixes #3843 (usage of Shaka without polyfills)
Re-opens #3530 (MediaCapabilities polyfill not working on Safari)

Change-Id: Ib5aff1b38759e1a39200332f3f07d3d6bd3bd2e1
joeyparrish added a commit that referenced this issue Jan 11, 2022
Revert "fix: Work around override of MediaCapabilities polyfill in Apple browsers (#3668)"

This reverts commit 31c0cd4.

Fixes #3843 (usage of Shaka without polyfills)
Re-opens #3530 (MediaCapabilities polyfill not working on Safari)

Change-Id: Ib5aff1b38759e1a39200332f3f07d3d6bd3bd2e1
joeyparrish added a commit that referenced this issue Jan 28, 2022
Revert "fix: Work around override of MediaCapabilities polyfill in Apple browsers (#3668)"

This reverts commit 31c0cd4.

Fixes #3843 (usage of Shaka without polyfills)
Re-opens #3530 (MediaCapabilities polyfill not working on Safari)

Backported to v3.1.x

Change-Id: Ib5aff1b38759e1a39200332f3f07d3d6bd3bd2e1
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Mar 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2022
@avelad avelad modified the milestones: v3.3, v4.0 May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants