Issue/3862 cmcd hls live multiple #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littlespex
commented
Jan 18, 2022
third_party/closure-uri/uri.js
Outdated
Comment on lines
811
to
832
| /** | ||
| * Sets a key value pair and removes all other keys with the same value. | ||
| * | ||
| * @param {string} key Name. | ||
| * @param {string} value Value. | ||
| * @return {!goog.Uri.QueryData} Instance of this object. | ||
| */ | ||
| goog.Uri.QueryData.prototype.set = function(key, value) { | ||
| this.ensureKeyMapInitialized_(); | ||
| // Invalidate the cache. | ||
| this.encodedQuery_ = null; | ||
|
|
||
| if (!this.keyMap_.hasOwnProperty(key)) { | ||
| this.add(key, value); | ||
| } | ||
| else { | ||
| this.keyMap_[key] = [value]; | ||
| } | ||
|
|
||
| return this; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Copying the exact implementation of this function required pulling in too many closure dependencies, so function was ported to match the spirit of the original.
There was a problem hiding this comment.
I might have done the same. Thanks for taking care of this!
joeyparrish
requested changes
Jan 18, 2022
littlespex
commented
Jan 19, 2022
|
@joeyparrish I'm not sure why the CI test are failing. They are DRM and UI related, and I don't think the CMCD changes would have caused them. Maybe they just need to be re-run? |
|
@joeyparrish can you review it? Thanks! |
|
We are still working on some flaky tests in the GitHub Actions environment. For now, please ignore those failures, which do not seem to be related to your work. |
joeyparrish
approved these changes
Jan 25, 2022
joeyparrish
pushed a commit
that referenced
this pull request
Jan 28, 2022
Use goog.Uri to append CMCD query data to avoid duplicate query params Fixes #3862 Co-authored-by: Dan Sparacio <daniel.sparacio@cbsinteractive.com>
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
goog.Urito append CMCD query data to avoid duplicate query paramsFixes #3862
Screenshots (optional)
Type of change
not work as expected)
Checklist:
./build/all.pyand the build passes./build/test.pyand all tests pass