Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add null check for emsgSchemeIdUris in streaming engine parseEMSG_ #3887

Merged
merged 1 commit into from Feb 9, 2022
Merged

add null check for emsgSchemeIdUris in streaming engine parseEMSG_ #3887

merged 1 commit into from Feb 9, 2022

Conversation

pcruiksh
Copy link
Contributor

@pcruiksh pcruiksh commented Jan 20, 2022 •
edited

Description

Add null check for emsgSchemeIdUris when EMSG boxes are parsed, as this value is null for HLS streams
Fixes #3886

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist:

  • I have signed the Google CLA https://cla.developers.google.com
  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have verified my change on multiple browsers on different platforms
  • I have run ./build/all.py and the build passes
  • I have run ./build/test.py and all tests pass

@joeyparrish joeyparrish merged commit 48433ab into shaka-project:master Feb 9, 2022
@github-actions github-actions bot mentioned this pull request Feb 12, 2022
Closed
joeyparrish pushed a commit that referenced this pull request Feb 16, 2022
@pcruiksh @joeyparrish
fix: Fix exception in StreamingEngine for EMSG with HLS (#3887)
ca1ca33 
Add null check for emsgSchemeIdUris when EMSG boxes are parsed, as this value is null for HLS streams

Fixes #3886
@github-actions github-actions bot mentioned this pull request Feb 16, 2022
Merged
joeyparrish pushed a commit that referenced this pull request Feb 16, 2022
@pcruiksh @joeyparrish
fix: Fix exception in StreamingEngine for EMSG with HLS (#3887)
b042358 
Add null check for emsgSchemeIdUris when EMSG boxes are parsed, as this value is null for HLS streams

Fixes #3886
@github-actions github-actions bot mentioned this pull request Feb 16, 2022
Merged
joeyparrish pushed a commit that referenced this pull request Feb 16, 2022
@pcruiksh @joeyparrish
fix: Fix exception in StreamingEngine for EMSG with HLS (#3887)
0c4a79f 
Add null check for emsgSchemeIdUris when EMSG boxes are parsed, as this value is null for HLS streams

Fixes #3886
joeyparrish pushed a commit that referenced this pull request Feb 16, 2022
@pcruiksh @joeyparrish
fix: Fix exception in StreamingEngine for EMSG with HLS (#3887)
02030bf 
Add null check for emsgSchemeIdUris when EMSG boxes are parsed, as this value is null for HLS streams

Fixes #3886
@github-actions github-actions bot mentioned this pull request Feb 16, 2022
Merged
@github-actions github-actions bot mentioned this pull request Mar 3, 2022
Merged
@github-actions github-actions bot mentioned this pull request Mar 22, 2022
Closed
@avelad avelad added this to the v4.0 milestone May 4, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.

Parsing EMSG for HLS CMAF streams fails with TypeError, missing null check
3 participants
@pcruiksh @joeyparrish @avelad