Fix download of some HLS assets #3934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there are a bunch of test failures in the compiled build. Please try running the tests with If they pass in uncompiled mode, that would imply some compiler issue. If they still fail, the stack trace should give you more information about what is wrong or missing. |
|
@joeyparrish I have managed to fix the error when compiling, I don't really know why it is, but it passes all the tests |
joeyparrish
approved these changes
Feb 10, 2022
joeyparrish
pushed a commit
that referenced
this pull request
Feb 16, 2022
Fix download of https://devstreaming-cdn.apple.com/videos/streaming/examples/img_bipbop_adv_example_ts/master.m3u8 The filterManifestByMediaCapabilities method is async, but the code doesn't wait for it to finish before continuing the download process. This PR fix it. This also fixes a hidden compiler issue caused by the use of an alias for StreamUtils.
joeyparrish
pushed a commit
that referenced
this pull request
Feb 16, 2022
Fix download of https://devstreaming-cdn.apple.com/videos/streaming/examples/img_bipbop_adv_example_ts/master.m3u8 The filterManifestByMediaCapabilities method is async, but the code doesn't wait for it to finish before continuing the download process. This PR fix it. This also fixes a hidden compiler issue caused by the use of an alias for StreamUtils.
joeyparrish
pushed a commit
that referenced
this pull request
Feb 16, 2022
Fix download of https://devstreaming-cdn.apple.com/videos/streaming/examples/img_bipbop_adv_example_ts/master.m3u8 The filterManifestByMediaCapabilities method is async, but the code doesn't wait for it to finish before continuing the download process. This PR fix it. This also fixes a hidden compiler issue caused by the use of an alias for StreamUtils.
joeyparrish
pushed a commit
that referenced
this pull request
Feb 16, 2022
Fix download of https://devstreaming-cdn.apple.com/videos/streaming/examples/img_bipbop_adv_example_ts/master.m3u8 The filterManifestByMediaCapabilities method is async, but the code doesn't wait for it to finish before continuing the download process. This PR fix it. This also fixes a hidden compiler issue caused by the use of an alias for StreamUtils.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix download of https://devstreaming-cdn.apple.com/videos/streaming/examples/img_bipbop_adv_example_ts/master.m3u8
The filterManifestByMediaCapabilities method is async, but the code doesn't wait for it to finish before continuing the download process. This PR fix it.