Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hls)!: HLS disabled in old browsers/platforms due to incompatibilities #3964

Merged
merged 1 commit into from Feb 18, 2022

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Feb 17, 2022

In Tizen 2/3 and WebOS 3.x there is no support for SourceBuffer.mode=sequence so as a result of change #2337, it necessary disable support for the HLS parser so that the user can at least use the native one with src= .

BEGIN_COMMIT_OVERRIDE
feat(hls)!: HLS disabled in old browsers/platforms due to incompatibilities (#3964)
END_COMMIT_OVERRIDE

@avelad avelad changed the title Disallow HLS parser in old browsers/platforms feat: disallow HLS parser in old browsers/platforms Feb 17, 2022
@avelad avelad changed the title feat: disallow HLS parser in old browsers/platforms feat(hls): disallow HLS parser in old browsers/platforms Feb 17, 2022
@joeyparrish
Copy link
Member

This is very unfortunate. However buggy or inefficient our old HLS implementation was, taking away HLS support on certain platforms would constitute a breaking change. That means a release with sequence mode support will have to be a v4.

Thank you for bringing this to our attention! I'll approve and merge this, and the next feature release will be v4.0. We will also need to remove support for all our v3 deprecated features.

@joeyparrish joeyparrish changed the title feat(hls): disallow HLS parser in old browsers/platforms feat!(hls): HLS parser disabled in old browsers/platforms Feb 17, 2022
@joeyparrish joeyparrish changed the title feat!(hls): HLS parser disabled in old browsers/platforms feat!(hls): HLS disabled in old browsers/platforms due to incompatibilities Feb 17, 2022
@joeyparrish joeyparrish merged commit 0daa00f into shaka-project:master Feb 18, 2022
@avelad avelad deleted the hls-support branch February 18, 2022 09:25
@joeyparrish joeyparrish changed the title feat!(hls): HLS disabled in old browsers/platforms due to incompatibilities feat(hls)!: HLS disabled in old browsers/platforms due to incompatibilities Mar 30, 2022
@avelad avelad added this to the v4.0 milestone May 4, 2022
@prate3k
Copy link

prate3k commented May 18, 2023

@avelad Are you able to run HLS streams after these changes? We're trying to make a similar change on top of v4.3.6 and its throwing "Possible encoding problem detected: Unexpected buffered range for reference". As I can see, your changes are pushed to v4.0.0 so does that work out-of-the box for you?

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants