fix(cea): make a more robust CEA MP4 parser #3965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
requested changes
Feb 17, 2022
lib/cea/mp4_cea_parser.js
Outdated
Comment on lines
241
to
245
| } catch (e) { | ||
| if (e instanceof shaka.util.Error) { | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't quite understand the logic here. Some comments may be helpful.
If the error is a shaka.util.Error, you break out of the loop. If it's some other kind of error, you continue. I don't understand the purpose of either.
There was a problem hiding this comment.
you are right, although the function really only throws this error, it can be applied to everything.
joeyparrish
requested changes
Feb 18, 2022
joeyparrish
approved these changes
Feb 24, 2022
|
Thanks @joeyparrish ! |
joeyparrish
pushed a commit
that referenced
this pull request
Mar 22, 2022
Fix a HLS error reported in #2337 (comment) Tested with https://devstreaming-cdn.apple.com/videos/streaming/examples/bipbop_adv_example_hevc/master.m3u8
joeyparrish
pushed a commit
that referenced
this pull request
Mar 22, 2022
Fix a HLS error reported in #2337 (comment) Tested with https://devstreaming-cdn.apple.com/videos/streaming/examples/bipbop_adv_example_hevc/master.m3u8
This was referenced Mar 22, 2022
This was referenced Mar 22, 2022
This was referenced Mar 22, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a HLS error reported in #2337 (comment)
Tested with https://devstreaming-cdn.apple.com/videos/streaming/examples/bipbop_adv_example_hevc/master.m3u8