Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play Range start and end settings #4026

Closed
hiren3897 opened this issue Mar 14, 2022 · 8 comments · Fixed by #4068 or #4009
Closed

Play Range start and end settings #4026

hiren3897 opened this issue Mar 14, 2022 · 8 comments · Fixed by #4068 or #4009
Assignees
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@hiren3897
Copy link

hiren3897 commented Mar 14, 2022

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
v3.3.2

Can you reproduce the issue with our latest release version?
NO

Can you reproduce the issue with the latest code from main?
NO

Are you using the demo app or your custom app?
Demo APP

If custom app, can you reproduce the issue using our demo app?
__

What browser and OS are you using?
Chrome, Firefox, safari edge on iOS, iPadOS, macOS, Linux, windows

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

https://dash.akamaized.net/akamai/bbb_30fps/bbb_with_tiled_thumbnails.mpd
https://multiplatform-f.akamaihd.net/i/multi/will/bunny/big_buck_bunny_,640x360_400,640x360_700,640x360_1000,950x540_1500,.f4v.csmil/master.m3u8

What configuration are you using? What is the output of player.getConfiguration()?

playRangeStart: 10,
playRangeEnd: 100

What did you do?

I try to set the start and end range for a VOD

What did you expect to happen?
To have a timeline same as start and end range declared

What happened?

When I try to apply the play range start and end for DASH, I have a perfect timeline UI with the range declared, but the video is stuck and doesn't play further unless I click the timeline it plays than when I take back the seek to the start it Stops again.
DASH

FOR HLS,
When we declare the range the UI is not well set up and when the video ends we are not able to play the video again.

HLS

For mp4, the settings are not applied.

Thanks

@hiren3897 hiren3897 added the type: bug Something isn't working correctly label Mar 14, 2022
@github-actions github-actions bot added this to the v3.3 milestone Mar 14, 2022
@joeyparrish
Copy link
Member

Thanks for the report. We will look into it.

@joeyparrish joeyparrish added the priority: P1 Big impact or workaround impractical; resolve before feature release label Mar 14, 2022
@hiren3897
Copy link
Author

Thanks 👍

@hiren3897
Copy link
Author

Hello, @joeyparrish Do we have any update on this bug?

@joeyparrish
Copy link
Member

It looks like the UI is building off of player.seekRange(), but seekRange() is reported incorrectly:

player.configure({playRangeStart: 10, playRangeEnd: 30});
player.seekRange()

{start: 10, end: 60}

@joeyparrish
Copy link
Member

Looks like PresentationTimeline has a bug, and our unit test for seekRange() doesn't exercise this case. When the manifest parser notifies the timeline of explicit segment times, rather than just a range, the playRangeEnd is ignored.

@joeyparrish joeyparrish self-assigned this Mar 28, 2022
joeyparrish added a commit to joeyparrish/shaka-player that referenced this issue Mar 28, 2022
For content where the manifest parser uses the notifySegments API
(DASH SegmentBase/SegmentList/SegmentTimeline, or HLS, but not DASH
SegmentTemplate+duration), the Player seekRangeEnd configuration was
not being honored correctly.

This fixes the issue in PresentationTimeline and adds a regression
test to our playRangeStart/playRangeEnds tests.

Fixed shaka-project#4026
joeyparrish added a commit to joeyparrish/shaka-player that referenced this issue Mar 28, 2022
For content where the manifest parser uses the notifySegments API
(DASH SegmentBase/SegmentList/SegmentTimeline, or HLS, but not DASH
SegmentTemplate+duration), the Player seekRangeEnd configuration was
not being honored correctly.

This fixes the issue in PresentationTimeline and adds a regression
test to our playRangeStart/playRangeEnds tests.

Fixed shaka-project#4026
joeyparrish added a commit to joeyparrish/shaka-player that referenced this issue Mar 28, 2022
For content where the manifest parser uses the notifySegments API
(DASH SegmentBase/SegmentList/SegmentTimeline, or HLS, but not DASH
SegmentTemplate+duration), the Player seekRangeEnd configuration was
not being honored correctly.

This fixes the issue in PresentationTimeline and adds a regression
test to our playRangeStart/playRangeEnds tests.

Fixed shaka-project#4026
@hiren3897
Copy link
Author

Thanks for the quick workaround on this issue.

I would also like to remind you that the UI build for DASH seems perfect but the video doesn't play at the start.
When I click ahead of the timeline then it starts playing because it fetches the segments to play but again when the I take back the timeline to zero the video is stopped.

For HLS,
The scenario is different, here the timeline is not built perfectly, and on the video ended we are not able to play the video again

These settings are also applied for mp4 VOD rather than DASH and HLS?

joeyparrish added a commit that referenced this issue Mar 29, 2022
For content where the manifest parser uses the notifySegments API
(DASH SegmentBase/SegmentList/SegmentTimeline, or HLS, but not DASH
SegmentTemplate+duration), the Player seekRangeEnd configuration was
not being honored correctly.

This fixes the issue in PresentationTimeline and adds a regression
test to our playRangeStart/playRangeEnds tests.

Fixed #4026
@joeyparrish
Copy link
Member

Please test again with the latest code from main or the nightly release. If the seek range is still incorrect, just put @shaka-bot reopen in a comment and this issue will be reopened. If there is another issue, such as a playback problem, please open a new issue. Thanks!

@hiren3897
Copy link
Author

hiren3897 commented Mar 31, 2022

I created a playback issue #4091

the setting seems to be perfect for both HLS and DASH VOD but it gives playback problem

joeyparrish added a commit that referenced this issue Apr 21, 2022
For content where the manifest parser uses the notifySegments API
(DASH SegmentBase/SegmentList/SegmentTimeline, or HLS, but not DASH
SegmentTemplate+duration), the Player seekRangeEnd configuration was
not being honored correctly.

This fixes the issue in PresentationTimeline and adds a regression
test to our playRangeStart/playRangeEnds tests.

Fixed #4026
joeyparrish added a commit that referenced this issue Apr 21, 2022
For content where the manifest parser uses the notifySegments API
(DASH SegmentBase/SegmentList/SegmentTimeline, or HLS, but not DASH
SegmentTemplate+duration), the Player seekRangeEnd configuration was
not being honored correctly.

This fixes the issue in PresentationTimeline and adds a regression
test to our playRangeStart/playRangeEnds tests.

Fixed #4026
joeyparrish added a commit that referenced this issue Apr 21, 2022
For content where the manifest parser uses the notifySegments API
(DASH SegmentBase/SegmentList/SegmentTimeline, or HLS, but not DASH
SegmentTemplate+duration), the Player seekRangeEnd configuration was
not being honored correctly.

This fixes the issue in PresentationTimeline and adds a regression
test to our playRangeStart/playRangeEnds tests.

Fixed #4026
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label May 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
2 participants