fix(cmcd): Fix Symbol usage in CMCD on Xbox One #4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joeyparrish can you test it in the Xbox? Thanks! |
joeyparrish
requested changes
Mar 29, 2022
lib/polyfill/symbol.js
Outdated
| if (!('description' in proto)) { | ||
| Object.defineProperty(proto, 'description', { | ||
| get: () => { | ||
| const m = /\((.*)\)/.exec(this.toString()); |
There was a problem hiding this comment.
Using this in an arrow function refers to the enclosing scope, here meaning the this of install(), which I believe is shaka.polyfill.Symbol.
I think you'll need to replace this arrow function with a function or method.
I have tested toString() and the regex on Xbox, and it should work otherwise.
There was a problem hiding this comment.
I took the liberty of making an edit to resolve this. I then tested it on Xbox, and the tests are passing.
This resolves both the use of `this` in an arrow function and compiler issues with the type of `this`.
joeyparrish
approved these changes
Mar 29, 2022
joeyparrish
changed the title
joeyparrish
added a commit
that referenced
this pull request
Apr 21, 2022
Close #4072 Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4072