Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hls): Support playing media playlists directly #4080

Merged
merged 3 commits into from Mar 31, 2022

Conversation

theodab
Copy link
Collaborator

@theodab theodab commented Mar 29, 2022

Closes #3536

@theodab theodab added the component: HLS The issue involves Apple's HLS manifest format label Mar 29, 2022
demo/custom.js Outdated
* @return {!Element} div
* @private
*/
makeAssetDialogContentsMediaPlaylist_(assetInProgress, inputsToCheck) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned that this extra tab may make the dialog too crowded. (I haven't cherry-picked this to look at the layout yet.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing this in person, we decided to keep the separate tab but rename it to be a more general-purpose "HLS" tab.

* directly.
* You can use the <code>shaka.util.MimeUtils.getFullType()</code> utility to
* format this value.
* <i>Defaults to <code>'video/mp4; codecs="avc1.42E01E"'</code>.</i>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should assume muxed content with AAC audio by default. (Add ", mp4a.40.2")

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the content is TS, I think that the default should be TS instead of MP4

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

externs/shaka/player.js Show resolved Hide resolved
// Parsing a media playlist results in a single-variant stream.
if (playlist.type == shaka.hls.PlaylistType.MEDIA) {
// Get necessary info for this stream, from the config. These are things
// we would normally be finding from the master playlist (e.g. from values
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "would normally find"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

- Fixed typos.
- Improved description in externs.
- Added audio to default media playlist codecs.
- Renamed some demo strings.
joeyparrish
joeyparrish previously approved these changes Mar 30, 2022
@joeyparrish
Copy link
Member

You have a new test that needs to be updated with the new default codec string. Looks good otherwise, though.

@joeyparrish joeyparrish merged commit 48dd205 into shaka-project:main Mar 31, 2022
@theodab theodab deleted the mediaPlaylistBranch branch March 31, 2022 00:29
@avelad avelad added this to the v4.0 milestone May 4, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support direct playback of HLS media playlists, without master playlist
3 participants