feat: add option for segment-relative VTT timings #4083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
elsassph
force-pushed
the
feature/text-offset-mode
branch
2 times, most recently
from
e61230c
to
0a1a3cd
Compare
joeyparrish
requested changes
Mar 30, 2022
elsassph
force-pushed
the
feature/text-offset-mode
branch
from
0a1a3cd
to
453bbdd
Compare
joeyparrish
requested changes
Mar 31, 2022
elsassph
force-pushed
the
feature/text-offset-mode
branch
3 times, most recently
from
f26d563
to
ad58e80
Compare
|
I'm going to try to add proper tests for the new config option - wish me luck. |
elsassph
force-pushed
the
feature/text-offset-mode
branch
from
ad58e80
to
0be7cc5
Compare
elsassph
force-pushed
the
feature/text-offset-mode
branch
from
0be7cc5
to
5cbe907
Compare
elsassph
changed the title
|
@joeyparrish now with some unit tests |
joeyparrish
previously approved these changes
Apr 1, 2022
joeyparrish
approved these changes
Apr 1, 2022
joeyparrish
requested changes
Apr 1, 2022
joeyparrish
approved these changes
Apr 1, 2022
|
Thanks for tidying up and approving @joeyparrish! |
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3242 where for some live streams using segmented VTT, text timings are relative to segment start instead of being absolute.
The PR introduces a new setting:
manifest.segmentRelativeVttTiming: booleanallowing such alternative timing offset calculation.The setting is off by default, preserving the current player behaviour.