Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix broken deps file generation on Windows #4086

Merged
merged 1 commit into from Mar 31, 2022

Conversation

joeyparrish
Copy link
Member

This fixes broken deps file generation on Window by upgrading to a
pre-release version of the deps tool. The upstream issue was filed in
google/closure-library#1159 and fixed in
google/closure-library#1160.

This issue has never affected a release version of Shaka Player, and
was introduced when we switched deps tools in 6f274cb.

Closes #4085

This fixes broken deps file generation on Window by upgrading to a
pre-release version of the deps tool.  The upstream issue was filed in
google/closure-library#1159 and fixed in
google/closure-library#1160.

This issue has never affected a release version of Shaka Player, and
was introduced when we switched deps tools in 6f274cb.

Closes shaka-project#4085
@joeyparrish joeyparrish merged commit 9660ce8 into shaka-project:main Mar 31, 2022
@joeyparrish joeyparrish deleted the fix-windows-jobs branch April 1, 2022 14:57
@avelad avelad added this to the v4.0 milestone May 4, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests failing consistently on Windows
3 participants