fix: Fix exceptions when quickly shutting down src= on Safari #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some events and timers were used to process track changes with src= playback on Safari, but they did not properly clean up when the player was unloaded or destroyed. In the case that this happened quickly after starting playback, exceptions would be thrown or tracks could manipulated after new content began. This fixes the cleanup of these timers and events to be aware of Player unloads or destruction. Closes shaka-project#4087
theodab
approved these changes
Mar 31, 2022
joeyparrish
added a commit
that referenced
this pull request
Apr 21, 2022
Some events and timers were used to process track changes with src= playback on Safari, but they did not properly clean up when the player was unloaded or destroyed. In the case that this happened quickly after starting playback, exceptions would be thrown or tracks could manipulated after new content began. This fixes the cleanup of these timers and events to be aware of Player unloads or destruction. Closes #4087
joeyparrish
added a commit
that referenced
this pull request
Apr 21, 2022
Some events and timers were used to process track changes with src= playback on Safari, but they did not properly clean up when the player was unloaded or destroyed. In the case that this happened quickly after starting playback, exceptions would be thrown or tracks could manipulated after new content began. This fixes the cleanup of these timers and events to be aware of Player unloads or destruction. Closes #4087
joeyparrish
added a commit
that referenced
this pull request
Apr 21, 2022
Some events and timers were used to process track changes with src= playback on Safari, but they did not properly clean up when the player was unloaded or destroyed. In the case that this happened quickly after starting playback, exceptions would be thrown or tracks could manipulated after new content began. This fixes the cleanup of these timers and events to be aware of Player unloads or destruction. Closes #4087
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some events and timers were used to process track changes with src=
playback on Safari, but they did not properly clean up when the player
was unloaded or destroyed. In the case that this happened quickly
after starting playback, exceptions would be thrown or tracks could
manipulated after new content began.
This fixes the cleanup of these timers and events to be aware of
Player unloads or destruction.
Closes #4087