Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HLS): Re-add TS support to Safari #4097

Merged
merged 1 commit into from Apr 2, 2022

Conversation

theodab
Copy link
Collaborator

@theodab theodab commented Apr 1, 2022

It appears that the problems we previously had with TS content
on Safari have been fixed. We no longer need the workaround where
we transmuxed TS on that platform.

It appears that the problems we previously had with TS content
on Safari have been fixed. We no longer need the workaround where
we transmuxed TS on that platform.
@theodab theodab added the browser: Safari Issues affecting Safari or WebKit derivatives label Apr 1, 2022
@theodab theodab requested a review from joeyparrish April 1, 2022 20:26
@theodab
Copy link
Collaborator Author

theodab commented Apr 1, 2022

I tried out a bunch of different TS assets on Safari, with native HLS disabled of course, and I didn't see any problems. Unless the original problem was the kind of thing that only showed up 1 out of every 100 plays or something, I think it's fixed by now.

@theodab
Copy link
Collaborator Author

theodab commented Apr 1, 2022

It looks like we still need to stub the abort function on Safari, though. I tried without it being stubbed, and sometimes things go wonky when you seek.

@joeyparrish joeyparrish merged commit 8a3bed7 into shaka-project:main Apr 2, 2022
@theodab theodab deleted the enableSafariTSBranch branch April 4, 2022 17:31
@avelad avelad added this to the v4.0 milestone May 4, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser: Safari Issues affecting Safari or WebKit derivatives status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants