New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Remove support for Safari 12 and iOS 12 #4112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
avelad
commented
Apr 11, 2022
•
edited by joeyparrish
edited by joeyparrish
- Remove support for Safari 12
- Support modern EME in Safari 13
- Remove EME Apple polyfill
- Update documentation
joeyparrish
changed the title
feat!: Remove support for Safari 12 and support modern EME in Safari 13
feat!: Remove support for Safari 12 and iOS 12
Apr 11, 2022
joeyparrish
approved these changes
Apr 11, 2022
Thanks for this! I'll add this to the v4 upgrade guide in my PR for that. |
This was referenced Apr 11, 2022
CHaNGeTe
reviewed
May 5, 2022
@@ -1254,28 +1253,6 @@ shaka.media.DrmEngine = class { | |||
}; | |||
this.activeSessions_.set(session, metadata); | |||
|
|||
/** | |||
* initDataTransform is only necessary when using legacy protection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contentID is only needed on legacy APIs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct
This was referenced May 16, 2022
This was referenced Jul 11, 2022
This was referenced Aug 11, 2022
This was referenced Aug 20, 2022
This was referenced Sep 15, 2022
This was referenced Sep 28, 2022
This was referenced Oct 10, 2022
github-actions
bot
added
the
status: archived
Archived and locked; will not be updated
label
Jul 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.