Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Remove small/large gap config, always jump gaps #4125

Merged
merged 2 commits into from Apr 13, 2022

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Apr 13, 2022

We get rid of the "small/large" gap concept, to always jump gaps by default

Related to issue #3188 (comment)

Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please also update docs/tutorials/upgrade.md?

@joeyparrish joeyparrish changed the title feat!: jump gaps always feat!: Remove small/large gap config, always jump gaps Apr 13, 2022
@avelad
Copy link
Collaborator Author

avelad commented Apr 13, 2022

Yes, but I can't continue working until Monday because I'm going on vacation until Monday.

@joeyparrish
Copy link
Member

Yes, but I can't continue working until Monday because I'm going on vacation until Monday.

Oh, then please don't worry. I'll make the update to the docs and merge the PR. Thanks!

@joeyparrish joeyparrish merged commit 0fd1999 into shaka-project:main Apr 13, 2022
@avelad avelad deleted the jump-gaps-always branch April 18, 2022 06:05
@avelad avelad added this to the v4.0 milestone May 4, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants