feat(hls): make a head request if hls subtitles have no extension #4140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
reviewed
Apr 19, 2022
| .setResponseText('test:/text', textMedia) | ||
| .setResponseText('test:/main.subs', vttText) | ||
| .setHeaders('test:/main.subs', { | ||
| 'content-type': 'application/mp4; foo=bar', |
There was a problem hiding this comment.
Would it be more realistic to give this a codec string? Perhaps something like TTML, which wouldn't otherwise be guessed by default?
There was a problem hiding this comment.
The function that has been modified only allows obtaining the mimetype, so entering codec information would not help.
joeyparrish
approved these changes
Apr 20, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4135
Closes #1959