fix(offline): Clean up orphaned segments on abort #4177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a storage operation is aborted (via API, not via closing the page), this will now be cleaned up from the database. More work is needed to find and remove orphaned segments in the database. Related to shaka-project#4166 and follow-up to PR shaka-project#4176.
theodab
requested changes
Apr 29, 2022
| * @param {number} manifestId | ||
| * @param {!shaka.extern.ManifestDB} manifestDB |
There was a problem hiding this comment.
The JSDoc needs to be updated again, now that this no longer loads the manifest.
There was a problem hiding this comment.
No, this is accurate. I added the parameter. Before, it was loaded inside the method. Now, it is provided by the caller, who already had a copy. The caller's copy is updated in-place as well as stored in the DB.
There was a problem hiding this comment.
Oh, wait, I see what you mean now. Yes, you're right. I'll take care of that.
There was a problem hiding this comment.
I wish Github let me comment on lines that the PR didn't change. It'd make this kind of thing so much clearer.
theodab
approved these changes
Apr 30, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a storage operation is aborted (via API, not via closing the page),
this will now be cleaned up from the database. More work is needed to
find and remove orphaned segments in the database.
Related to #4166 and follow-up to PR #4176.