Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PERIOD_FLATTENING_FAILED error when periods have different base sample types. #4206

Merged
merged 12 commits into from May 17, 2022

Conversation

ghouet
Copy link
Contributor

@ghouet ghouet commented May 9, 2022

Closes #4202

@ghouet ghouet changed the title Fix PERIOD_FLATTENING_FAILED error when periods have different base sample types. fix: PERIOD_FLATTENING_FAILED error when periods have different base sample types. May 9, 2022
lib/util/mime_utils.js Outdated Show resolved Hide resolved
@avelad avelad added the type: bug Something isn't working correctly label May 9, 2022
@avelad avelad added this to the v4.1 milestone May 9, 2022
lib/util/mime_utils.js Outdated Show resolved Hide resolved
lib/util/mime_utils.js Outdated Show resolved Hide resolved
joeyparrish
joeyparrish previously approved these changes May 9, 2022
@avelad avelad added the component: DASH The issue involves the MPEG DASH manifest format label May 10, 2022
the codec string indicates a container difference which may be incompatible when switching from one to another.
lib/util/mime_utils.js Outdated Show resolved Hide resolved
lib/util/mime_utils.js Outdated Show resolved Hide resolved
lib/util/mime_utils.js Outdated Show resolved Hide resolved
lib/util/mime_utils.js Show resolved Hide resolved
lib/util/mime_utils.js Outdated Show resolved Hide resolved
lib/util/mime_utils.js Outdated Show resolved Hide resolved
lib/util/mime_utils.js Outdated Show resolved Hide resolved
@ghouet ghouet requested a review from joeyparrish May 12, 2022 03:14
@joeyparrish joeyparrish merged commit b757a81 into shaka-project:main May 17, 2022
joeyparrish pushed a commit that referenced this pull request May 17, 2022
joeyparrish pushed a commit that referenced this pull request May 17, 2022
joeyparrish pushed a commit that referenced this pull request May 17, 2022
nyanmisaka added a commit to nyanmisaka/shaka-player that referenced this pull request Oct 6, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: DASH The issue involves the MPEG DASH manifest format status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PERIOD_FLATTENING_FAILED Error when playing mixed hvc1/hev1 or dvhe/dvh1 periods.
3 participants