New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: PERIOD_FLATTENING_FAILED error when periods have different base sample types. #4206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ec but different base sample types.
ghouet
changed the title
Fix PERIOD_FLATTENING_FAILED error when periods have different base sample types.
fix: PERIOD_FLATTENING_FAILED error when periods have different base sample types.
May 9, 2022
avelad
reviewed
May 9, 2022
joeyparrish
requested changes
May 9, 2022
joeyparrish
requested changes
May 9, 2022
joeyparrish
previously approved these changes
May 9, 2022
avelad
added
the
component: DASH
The issue involves the MPEG DASH manifest format
label
May 10, 2022
… string. Also fix issue in getCodecParts_.
avelad
reviewed
May 11, 2022
the codec string indicates a container difference which may be incompatible when switching from one to another.
joeyparrish
requested changes
May 11, 2022
joeyparrish
requested changes
May 12, 2022
joeyparrish
approved these changes
May 17, 2022
nyanmisaka
added a commit
to nyanmisaka/shaka-player
that referenced
this pull request
Oct 6, 2022
…ferent base sample types (shaka-project#4206)" This reverts commit 0482aec.
github-actions
bot
added
the
status: archived
Archived and locked; will not be updated
label
Jul 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
component: DASH
The issue involves the MPEG DASH manifest format
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4202