fix: Fix exception with streaming.startAtSegmentBoundary #4216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v4.0.0 introduced a regression. When SegmentIterator's seek() method was removed, one reference to it was missed in Player. This was only used when streaming.startAtSegmentBoundary is true, and there were no tests to exercise that code path. This adds new tests and fixes the regression. Closes shaka-project#4188
littlespex
approved these changes
May 11, 2022
This was referenced May 11, 2022
joeyparrish
added a commit
that referenced
this pull request
May 17, 2022
v4.0.0 introduced a regression. When SegmentIterator's seek() method was removed, one reference to it was missed in Player. This was only used when streaming.startAtSegmentBoundary is true, and there were no tests to exercise that code path. This adds new tests and fixes the regression. Closes #4188
joeyparrish
added a commit
that referenced
this pull request
May 17, 2022
v4.0.0 introduced a regression. When SegmentIterator's seek() method was removed, one reference to it was missed in Player. This was only used when streaming.startAtSegmentBoundary is true, and there were no tests to exercise that code path. This adds new tests and fixes the regression. Closes #4188
joeyparrish
added a commit
that referenced
this pull request
May 17, 2022
v4.0.0 introduced a regression. When SegmentIterator's seek() method was removed, one reference to it was missed in Player. This was only used when streaming.startAtSegmentBoundary is true, and there were no tests to exercise that code path. This adds new tests and fixes the regression. Closes #4188
nyanmisaka
added a commit
to nyanmisaka/shaka-player
that referenced
this pull request
Oct 6, 2022
…ka-project#4216)" This reverts commit 24eac2c.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.0.0 introduced a regression. When SegmentIterator's seek() method
was removed, one reference to it was missed in Player. This was only
used when streaming.startAtSegmentBoundary is true, and there were no
tests to exercise that code path.
This adds new tests and fixes the regression.
Closes #4188