Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing to the migration to a new build system #4423

Closed
IsaacSNK opened this issue Aug 18, 2022 · 3 comments
Closed

Contributing to the migration to a new build system #4423

IsaacSNK opened this issue Aug 18, 2022 · 3 comments
Labels
status: archived Archived and locked; will not be updated type: question A question from the community

Comments

@IsaacSNK
Copy link
Contributor

Hi Team. I've seen many comments in different threads about migrating Shaka to a new build system. Do you have any roadmap or a list of changes that you think are required for this to happen? I can definitely contribute with a few hours of my time every week.

@IsaacSNK IsaacSNK added the type: question A question from the community label Aug 18, 2022
@joeyparrish
Copy link
Member

At this point, we don't have a concrete plan. I suspect it is best left until a TypeScript migration, at which point the old build scripts and compiler will be easily deleted.

@IsaacSNK
Copy link
Contributor Author

IsaacSNK commented Aug 18, 2022

Is it worth migrating start by changing the code to use ESModules instead of goog.require and goog.provide? Assumming that Closure plays well with ESModules. I'm thinking that doing small incremental changes like that will make it easier to fully migrate to something else

@joeyparrish
Copy link
Member

Perhaps. It has been discussed (here and here), but I've done very little research on this personally.

If people would like to experiment with this, I would suggest we start a new branch for it and PR into that branch. I would want to avoid doing releases from main with a half-complete implementation of a goog.module transition.

Let's move discussion to #2647, though, since we already have an open issue for goog.module.

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Oct 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: question A question from the community
Projects
None yet
Development

No branches or pull requests

2 participants