New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
High Media Start Up on Shaka 4.x #6219
Comments
There may be a performance regression. We will need to look into it. I see you have tried v4.3.0, which is out of date. Can you try the latest v4.7 release? (Currently v4.7.9, but v4.7.10 will be out in the next couple days.) There have been many performance-related PRs since v4.3. |
@joeyparrish Unfortunately, moving to 4.7.9 version would be difficult for us to incorporate. I'll review the changelog for 4.7.9, meanwhile if you have anything specific in mind we can look at, do let us know. |
We just released v4.7.10. I also cherry-picked everything I could into v4.3.14 (since v4.3 is our current LTS branch), but many changes did not apply in that branch. If v4.3.14 doesn't help, you will need to move to a newer feature branch in order to get the necessary changes. You can find our branch maintenance policy here: https://shaka-project.github.io/maintenance/shaka-player.html#branch-maintenance-policy and our list of currently-maintained branches here: https://github.com/shaka-project/shaka-player/blob/main/maintained-branches.md And if none of these things help, we will need to do additional work, which would land in But you have to understand that we aren't going to dive into a performance issue in v4.3.0, which is already 15 months old and 14 bugfix releases out of date. It's not practical. You at least have to try v4.3.14 (latest bugfix for the branch you're on) and v4.7.10 (latest release overall) before we will dig deeper, in case your issue has already been fixed in the 15 months since v4.3.0 came out. Thanks! |
Closing due to inactivity. If this is still an issue for you or if you have further questions, the OP can ask shaka-bot to reopen it by including |
One thing we noticed is that usage of mediaCapabilities.decodingInfo API for filtering manifest is causing extra time. For content with a lot of variants, etc 100+, it could be quite a burden for LR device. (If 5ms each, then we end up spending 500ms) Is there any suggestion on how to improve over this part? |
I checked latest main branch and I found related code only gets more complicated by adding support for multi codec/mimeType variant. After checking polyfill for mediaCapabilities and I think at least for LR, there could be some room for performance improvement. Trying to reduce the calls to API, by inferring result of one variant from another. Also needs to add a config to control this, so that can switch between compatible mode and performance mode. categoryCache=new Map();
for(const variant of variants) {
// if key is a counter/random number, then execute for all variants, a compatible mode versus a performance mode
const categoryKey = buildKey(variant);
if(categoryCache.has(categoryKey)) {
variant.decodingInfo= categoryCache.get(categoryKey)
}else {
const res = MediaCapability.getDecodingInfo(variant);
// if it's supported or smooth
if(shouldCache(res)) {
categoryCache.set(categoryKey, res)
}
}
} |
@shaka-bot reopen |
@Strongbow19 are you interested on send a PR to fix it? |
@jaskarancodes Does this answer all your questions? If so, would you please close the issue? |
Closing due to inactivity. If this is still an issue for you or if you have further questions, the OP can ask shaka-bot to reopen it by including |
Have you read the Tutorials?
Yes
Have you read the FAQ and checked for duplicate open issues?
Yes
If the question is related to FairPlay, have you read the tutorial?
NA
What version of Shaka Player are you using?
4.3.0
What browser and OS are you using?
WebOS and Tizen (All Models year 2017 onwards)
Please ask your question
Team, we recently migrated from Shaka 2.5.10 (main) to Shaka 4.3.0 (8a10a95). Post upgrading, we are seeing an increase in start lag of about 2.5s on Tizen and WebOS platforms. From our observations, the start lag seems to be higher on DRM contents and even higher on multi-key DRM contents as compared to Shaka 2.5.10. Need some suggestions on the most optimal way to reduce the media start-up time. We are using the following player configuration for the Shaka 4.3.0 player
The text was updated successfully, but these errors were encountered: