Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak on multi-period streams #6239

Open
bbert opened this issue Feb 9, 2024 · 4 comments
Open

Memory leak on multi-period streams #6239

bbert opened this issue Feb 9, 2024 · 4 comments
Labels
component: DASH The issue involves the MPEG DASH manifest format flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this priority: P2 Smaller impact or easy workaround status: waiting on response Waiting on a response from the reporter(s) of the issue type: performance A performance issue
Milestone

Comments

@bbert
Copy link

bbert commented Feb 9, 2024

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

Yes

What version of Shaka Player are you using?

4.2.x => 4.7.x

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Demo app

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
chrome, windows

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

https://d24rwxnt7vw9qb.cloudfront.net/v1/dash/e6d234965645b411ad572802b6c9d5a10799c9c1/All_Reference_Streams/4577dca5f8a44756875ab5cc913cd1f1/index.mpd

What configuration are you using? What is the output of player.getConfiguration()?

Default

What did you do?

Play stream and take memory heap snapshots using chrome dev tools at different times

What did you expect to happen?
Memory heap to be stable

What actually happened?

Memory heap grows consistently for multi-period streams.
On mono-period streams, we dot not notice the same result.

Please find screenshots:

  • Heap snapshots to illustrate inscrease of memory consumption:
    image

  • Snapshots comparison after 45 minutes
    image

  • Details and allocation call stack (based on v4.5.x) of retained objects
    image

Please note that all objects (Text, Element, NodeList ...) are allocated in the same place.

@bbert bbert added the type: bug Something isn't working correctly label Feb 9, 2024
@bbert bbert changed the title Memory on multi-period streams Memory leak on multi-period streams Feb 9, 2024
@shaka-bot shaka-bot added this to the v5.0 milestone Feb 9, 2024
@avelad
Copy link
Collaborator

avelad commented Feb 19, 2024

Duplicate of #6070

@avelad avelad marked this as a duplicate of #6070 Feb 19, 2024
@avelad avelad closed this as completed Feb 19, 2024
@avelad avelad added status: duplicate A duplicate of another issue; should be closed after linking to the original issue and removed type: bug Something isn't working correctly labels Feb 19, 2024
@bbert
Copy link
Author

bbert commented Feb 19, 2024

I'm not sure this is a duplicate of #6070 since #6070 memory issue is related to SegmentTimeline and the one described in this issue is more generally related to multi-periods, and noticeably since at least v 4.2.x.

@joeyparrish
Copy link
Member

Reopening.

@joeyparrish joeyparrish reopened this Feb 21, 2024
@joeyparrish joeyparrish added type: performance A performance issue priority: P2 Smaller impact or easy workaround component: DASH The issue involves the MPEG DASH manifest format flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this and removed status: duplicate A duplicate of another issue; should be closed after linking to the original issue labels Feb 21, 2024
@avelad avelad modified the milestones: v4.8, v4.9 Apr 26, 2024
@avelad
Copy link
Collaborator

avelad commented May 6, 2024

@bbert Can you test if it still happens with 4.8.1? Thanks!

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DASH The issue involves the MPEG DASH manifest format flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this priority: P2 Smaller impact or easy workaround status: waiting on response Waiting on a response from the reporter(s) of the issue type: performance A performance issue
Projects
None yet
Development

No branches or pull requests

4 participants