Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onEnded Event Fails to Trigger on Specific LG Devices and Set Top Boxes #6427

Open
samueleastdev opened this issue Apr 10, 2024 · 1 comment
Labels
flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this platform: TV/STB Issues affecting smart TV or set-top box platforms platform: WebOS Issues affecting WebOS priority: P3 Useful but not urgent type: bug Something isn't working correctly
Milestone

Comments

@samueleastdev
Copy link

samueleastdev commented Apr 10, 2024

What version of Shaka Player are you using?

Shaka: 4.7.12

Can you reproduce the issue with our latest release version?

Yes

What browser and OS are you using?

We are seeing the issue on LG 43UR78003LK - 2023 and also on our STB running.

Mozilla/5.0, AppleWebKit/537.36, Chrome/92.0.4515.159, Safari/537.36, OPR/46.0.2207.0, OMI/4.22.1, VODAFONE_STB/7.2.A002.99aa.huad BCM72604/7.2.A002.99aa.huad/DCI362/MEDIUM (Sagemcom_Broadband_SAS, DCI362_UHD_VF_HU, Wired)

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

All the information i have so far: LG 43UR78003LK - 2023 will try to get more if needed

What did you do?

I have both a basic setup and a Shaka setup. Upon testing Shaka on LG devices and our STB, the onEnded event does not fire.
I have created a demo link here.

https://58boel1q56.execute-api.eu-central-1.amazonaws.com/dev/

Additionally, here is a video demonstrating the issue, first tested on the STB and then on the browser for reference. You won't see the video in the STB inspector — that's normal, but it is playing on the STB.

The basic setup uses an MP4 file, while the Shaka setup utilizes a DASH stream. You can see everything in the source of the demo link.

ShakaPlayerOnEndedBug.mp4

What did you expect to happen?

onEnded event to fire

What actually happened?

onEnded event does not fire

@samueleastdev samueleastdev added the type: bug Something isn't working correctly label Apr 10, 2024
@avelad avelad added platform: TV/STB Issues affecting smart TV or set-top box platforms platform: WebOS Issues affecting WebOS labels Apr 10, 2024
@avelad
Copy link
Collaborator

avelad commented Apr 10, 2024

These devices are supported by the community, we do not have these devices in the laboratory to test it. Are you interested in finding the bug and submitting a PR? Thanks!

@avelad avelad added the flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this label Apr 10, 2024
@shaka-bot shaka-bot added this to the v5.0 milestone Apr 10, 2024
@joeyparrish joeyparrish added the priority: P3 Useful but not urgent label Apr 12, 2024
@avelad avelad modified the milestones: v4.8, v4.9 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this platform: TV/STB Issues affecting smart TV or set-top box platforms platform: WebOS Issues affecting WebOS priority: P3 Useful but not urgent type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants