Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Hide / show player UI controls on tap #6490

Open
MarianoFacundoArch opened this issue Apr 26, 2024 · 2 comments
Open

[UI] Hide / show player UI controls on tap #6490

MarianoFacundoArch opened this issue Apr 26, 2024 · 2 comments
Labels
component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent type: enhancement New feature or request
Milestone

Comments

@MarianoFacundoArch
Copy link
Contributor

Describe the solution you'd like
Like YouTube does on mobile, when we tap the player, the controls should be shown, but when we click again, they should be hidden. Maybe a configuration in the UI to enable this behavior would be great.

@MarianoFacundoArch MarianoFacundoArch added the type: enhancement New feature or request label Apr 26, 2024
@shaka-bot shaka-bot added this to the Backlog milestone Apr 26, 2024
@avelad avelad added component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent labels Apr 29, 2024
@avelad
Copy link
Collaborator

avelad commented Apr 29, 2024

@MarianoFacundoArch Are you interested in submitting a PR to implement it? Thanks!

@MarianoFacundoArch
Copy link
Contributor Author

Hi Avelad!
Of course, I tried first to deploy it directly on my app to test, but I could not.
I tried doing a simple hide ui (the new method) when I detected a click on the controls or video container, but even though the event listener was fired (I did a console log), the ui was not hidden.
So I could not continue with that, I guess there is some interaction I might not be understanding. My idea was to do it myself and submit a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants