From 23481464ede6ab3c8f76718c2a4db05b730e6b6d Mon Sep 17 00:00:00 2001 From: Alvaro Velad Date: Fri, 20 Aug 2021 10:38:02 +0200 Subject: [PATCH 1/3] Always polyfill MediaCapabilities for Apple browsers --- lib/polyfill/media_capabilities.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/polyfill/media_capabilities.js b/lib/polyfill/media_capabilities.js index 211a1311c2..8583354b50 100644 --- a/lib/polyfill/media_capabilities.js +++ b/lib/polyfill/media_capabilities.js @@ -27,7 +27,12 @@ shaka.polyfill.MediaCapabilities = class { // Since MediaCapabilities is not fully supported on Chromecast yet, we // should always install polyfill for Chromecast. // TODO: re-evaluate MediaCapabilities in the future versions of Chromecast. - if (!shaka.util.Platform.isChromecast() && navigator.mediaCapabilities) { + // Since MediaCapabilities is not fully supported on Apple browsers yet, we + // should always install polyfill for Apple browsers. + // TODO: re-evaluate MediaCapabilities in the future versions of Apple Browsers. + if (!shaka.util.Platform.isChromecast() && + !shaka.util.Platform.isApple() && + navigator.mediaCapabilities) { shaka.log.debug( 'MediaCapabilities: Native mediaCapabilities support found.'); return; From 6a41030b9c430bde83b89b7629bf59b593e8992b Mon Sep 17 00:00:00 2001 From: Alvaro Velad Date: Fri, 20 Aug 2021 17:46:08 +0200 Subject: [PATCH 2/3] Fix line length --- lib/polyfill/media_capabilities.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/polyfill/media_capabilities.js b/lib/polyfill/media_capabilities.js index 8583354b50..2697a38e97 100644 --- a/lib/polyfill/media_capabilities.js +++ b/lib/polyfill/media_capabilities.js @@ -29,7 +29,8 @@ shaka.polyfill.MediaCapabilities = class { // TODO: re-evaluate MediaCapabilities in the future versions of Chromecast. // Since MediaCapabilities is not fully supported on Apple browsers yet, we // should always install polyfill for Apple browsers. - // TODO: re-evaluate MediaCapabilities in the future versions of Apple Browsers. + // TODO: re-evaluate MediaCapabilities in the future versions of Apple + // Browsers. if (!shaka.util.Platform.isChromecast() && !shaka.util.Platform.isApple() && navigator.mediaCapabilities) { From f0b0d3bf0aefb1854aad54ea3a701f42f7d7ebc5 Mon Sep 17 00:00:00 2001 From: Alvaro Velad Date: Fri, 20 Aug 2021 17:47:55 +0200 Subject: [PATCH 3/3] Change comment --- lib/polyfill/media_capabilities.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/polyfill/media_capabilities.js b/lib/polyfill/media_capabilities.js index 2697a38e97..fb977a51f6 100644 --- a/lib/polyfill/media_capabilities.js +++ b/lib/polyfill/media_capabilities.js @@ -27,8 +27,9 @@ shaka.polyfill.MediaCapabilities = class { // Since MediaCapabilities is not fully supported on Chromecast yet, we // should always install polyfill for Chromecast. // TODO: re-evaluate MediaCapabilities in the future versions of Chromecast. - // Since MediaCapabilities is not fully supported on Apple browsers yet, we + // Since MediaCapabilities implementation is buggy in Apple browsers, we // should always install polyfill for Apple browsers. + // See: https://github.com/google/shaka-player/issues/3530 // TODO: re-evaluate MediaCapabilities in the future versions of Apple // Browsers. if (!shaka.util.Platform.isChromecast() &&