Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring the output format #31

Open
Romantic-LiXuefeng opened this issue Oct 15, 2019 · 4 comments
Open

Add support for configuring the output format #31

Romantic-LiXuefeng opened this issue Oct 15, 2019 · 4 comments
Labels
priority: P2 Smaller impact or easy workaround type: enhancement New feature or request
Milestone

Comments

@Romantic-LiXuefeng
Copy link

In my user case, we don't need to output DASH. Just need to output HLS with TS, so hope to support to configure the output container format.

@Angels-group
Copy link

In my user case, we don't need to output DASH. Just need to output HLS with TS, so hope to support to configure the output container format.

You can configure in pipeline config:

# Manifest format (dash, hls or both)
manifest_format:
  - dash
  - hls

https://github.com/google/shaka-streamer/blob/master/config_files/pipeline_vod_config.yaml

@Romantic-LiXuefeng
Copy link
Author

Romantic-LiXuefeng commented Oct 15, 2019

To clear that, just need to output HLS with TS container, now the pipeline config default support to output with m4s.

@ismena
Copy link
Contributor

ismena commented Oct 15, 2019

@Romantic-LiXuefeng Thanks for bringing this up, we don't have support for configuring container yet (we only do mp4 now, as you've noticed).

Having this is a great idea, though, so I'm tagging this as an enhancement, and we'll work on it.

If you're interested in mp4/HLS in the meantime, @Angels-group's advice is spot on, just set the manifest_format field to hls and we'll do it.

@ismena ismena added type: enhancement New feature or request and removed needs triage labels Oct 15, 2019
@joeyparrish
Copy link
Member

Until we offer a configuration for this, you can check out the source code and change "mp4" to "ts" in both get_output_format methods in streamer/bitrate_config.py. That should allow to you test your workflow in the mean time.

@shaka-bot shaka-bot added this to the Backlog milestone Oct 15, 2019
@joeyparrish joeyparrish changed the title Add support for configuring the output format when just using HLS Add support for configuring the output format Oct 16, 2019
@joeyparrish joeyparrish added the priority: P2 Smaller impact or easy workaround label Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P2 Smaller impact or easy workaround type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants