-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serving static content from sys link directory is not working #20
Comments
what do you mean by sys link? are you on windows? can you browse this folder using file explorer? |
I am on Mac and I can browse the files, I am not sure what is the problem if I replaced the sys linked folder with actual bower_components it works. I am using docker on mac os. |
Do you mean symlinked? Could you prepare github repository to reproduce this issue? |
I think the problem with docker. |
I just encountered the same issue. The root cause appears to be that I fixed this by changing the
This is a bit of a corner case though, but it might be sensible by default to generate relative symlinks? |
interesting @hsalokor @GabLeRoux @samypr100 do relative symlinks work with windows junctions? |
I have no access right now to a Windows machine in order to test, but Node.js fs-module documentation seems to suggest that the above code would work, but would create absolute junction.
It probably needs some testing in real Windows environment - I think it would be acceptable to create relative links on OS X and Linux, and fall back to absolute paths on Windows. |
I've created this repository to give this issue a try: In an administrator shell on Windows 10, I did this:
It worked well as expected, I used bower-away --version
1.1.2 I will try with this when I get some more time. -"postinstall": "node -e \"try { require('fs').symlinkSync(require('path').resolve('node_modules/@bower_components'), 'public/libs', 'junction') } catch (e) { }\""
+"postinstall": "node -e \"try { require('fs').symlinkSync('../node_modules/@bower_components', 'public/libs', 'junction') } catch (e) { }\"" |
Hint: I'm using a windows vm from Microsoft modern.ie's vms. This way, everybody can test on windows, but it takes a few minutes to setup. 👍 |
I followed the instruction and I get a sys link folder bower_components linked to @bower_components in npm and when I refresh the index page it gives me 404.
The text was updated successfully, but these errors were encountered: