Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semver is translated in an invalid #tag #29

Open
Pictor13 opened this issue Jul 13, 2018 · 0 comments
Open

Semver is translated in an invalid #tag #29

Pictor13 opened this issue Jul 13, 2018 · 0 comments

Comments

@Pictor13
Copy link

Pictor13 commented Jul 13, 2018

I tried to run bower-away on a bower package and got some @namepaced dependencies that cannot resolve the correct #tag, in the peerDependencies of package.json (when running npm install).

{
  "dependencies": {
    "jquery": ">=1.7.0",
    "microplugin": "0.0.x",
    "sifter": "0.5.x"
  },
  "devDependencies": {
    "bootstrap2": "bootstrap#2",
    "bootstrap3": "bootstrap#3.2"
  }
}

becomes

"dependencies": {
    "@bower_components/bootstrap2": "twbs/bootstrap#2",
    "@bower_components/bootstrap3": "twbs/bootstrap#3.2",
    "@bower_components/jquery": "jquery/jquery-dist#>=1.8.0 <2.1.0",
    "@bower_components/microplugin": "brianreavis/microplugin.js#0.0.x",
    "@bower_components/sifter": "brianreavis/sifter.js#0.5.x",
  },

and generates a

npm ERR! git rev-list -n1 0.0.x: fatal: ambiguous argument '0.0.x': unknown revision or path not in the working tree.
npm ERR! git rev-list -n1 %3E=1.8.0%20%3C2.1.0: fatal: ambiguous argument '%3E=1.8.0%20%3C2.1.0': unknown revision or path not in the working tree.

Example:
In the case of "@bower_components/sifter":"brianreavis/sifter.js#0.5.1" the correct tag to resolve would be pointed by "brianreavis/sifter.js#v0.5.1".

Is it a naming problem of the libraries, over the bower registry/manifest, or is bower-away missing from checking the existence of that #tag on the repositories that are being required?

While digging I've found this #322 and I am wondering if it makes sense to use the ver.si.on in order to generate a #tag (is it the case?).

I dunno much of node.js so am not sure where the _target, in the script, is coming from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant