New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Difference from standard #13
Comments
I think it is a bug on standard.js side, as whitespace makes sense there if we want to maintain line-length limit. I'd prefer to be more compatible with prettier than standard on this matter. I'd suggest raising this issue (or sending a PR) at https://github.com/feross/eslint-config-standard |
OR you could argue this should be changed at https://github.com/prettier/prettier |
This brings up a wider question to me: does this package provide anything more for me than just using prettier like this?
I know it was mentioned briefly in the prettier library, but I'm just wondering why I would use It seems like this library is actually not all that related to standard, since it doesn't use standard for formatting, and allows for rules to be overridden, which goes directly against the philosophy of standard to "just pick something". I'm also concerned with I'm just afraid that if I use this, harmony between the |
By "doesn't use standard for formatting" I just meant the My goal is to make prettier-standard respect most of formatting rules from standard.
Base formatting rules are minimal and currently defined here: |
Standard does not enforce line length limits. To impose them here seems counter-intuitive.
Thanks for clarifying your preference; for now I'll stick with standard Standard. I'm fine with this issue being closed unless you'd like to keep it open for others to have a broader discussion. |
Right, but the snippet I posted included
I generally agree that allowing for configuration of tools is valuable for developers, and that is exactly what ESLint provides. But Standard was built explicitly to avoid manual configuration and bikeshedding.
It's not that I don't like the use of the I don't want to have to maintain a Correct me if I'm wrong, but this library seems to conflict with that idea. It contains deviations from Standard, allows for rule changing and extension, and I'm not entirely sure what it provides someone over just using |
I want to make it clear that I am not trying to attack this library—I think it's awesome that it was created. I'm just trying to understand it. I love the concepts of But I am confused how this library gets me there. I would like to understand it better. |
@indiesquidge I think as a compromise we could introduce --strict flag, so 100% of standard rules are enforced, even these that don't make sense to me in light of prettier formatting I'll accept the PR if anyone sends it |
Upon further requests I've decided to add all fixable rules from standard. This behavior is releasd in prettier-standard 6.0.0. Please not that the rule that is the subject of this issue is not fixable. This might be somehow solved in the future by #17 |
https://gist.github.com/johnmuhl/4592c57c0b1c85e5b4c8f035c3ecf6eb
The
configuration-original.js
file is generated by therails/webpacker
gem;configuration.js
is the result of runningprettifier-standard
.standard-out.sh
shows the offending code; i.e.Standard 10.x and 9.x show the same error.
The text was updated successfully, but these errors were encountered: