Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cd.js swallows the initial error #1132

Closed
iuliana opened this issue Sep 1, 2023 · 1 comment
Closed

cd.js swallows the initial error #1132

iuliana opened this issue Sep 1, 2023 · 1 comment

Comments

@iuliana
Copy link

iuliana commented Sep 1, 2023

Node version (or tell us if you're using electron or some other framework):

not relevant

ShellJS version (the most recent version/Github branch you see the bug on):

v0.5.8

Operating system:

not relevant

Description of the bug:

The current implementation of cd.js is swallowing the actual error. The exception caught in line 27 (e) is not logged nor used further in the the error handling. This hides errors such as chdir not supported in worker threads or other causes not covered by the current handling error code in this file.

Example ShellJS command to reproduce the error:

Not needed as this is just an observation on the code.

@iuliana
Copy link
Author

iuliana commented Sep 5, 2023

Duplicate of : #1112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant