Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sed with -i option now runs silently #959

Merged
merged 5 commits into from
Jan 15, 2022
Merged

Conversation

joshi-sh
Copy link
Contributor

Fixes issue #159 with shx

@codecov-io
Copy link

codecov-io commented Aug 10, 2019

Codecov Report

Merging #959 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
+ Coverage   97.28%   97.28%   +<.01%     
==========================================
  Files          34       34              
  Lines        1289     1291       +2     
==========================================
+ Hits         1254     1256       +2     
  Misses         35       35
Impacted Files Coverage Δ
src/sed.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57df38c...4eb4d74. Read the comment docs.

@nfischer nfischer added the breaking Breaking change label Aug 13, 2019
test/sed.js Show resolved Hide resolved
@zone117x
Copy link

Hi all, is there anything preventing this PR from merging?

@catchmareck
Copy link

I need that too :/ could you please merge this?

@nfischer nfischer added bash compat Compatibility issues with bash or POSIX behavior fix Bug/defect, or a fix for such a problem labels Jan 15, 2022
@nfischer nfischer merged commit b473f2e into shelljs:master Jan 15, 2022
@pringshia
Copy link

Any plans on when the next release might be? Would be great to get this into shx.

@nfischer nfischer added this to the v0.9.0 milestone May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash compat Compatibility issues with bash or POSIX behavior breaking Breaking change fix Bug/defect, or a fix for such a problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sed should be silent if '-i' is provided
6 participants